Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipip-0288 lacking etag clarity #490

Open
SgtPooki opened this issue Feb 11, 2025 · 0 comments
Open

ipip-0288 lacking etag clarity #490

SgtPooki opened this issue Feb 11, 2025 · 0 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Feb 11, 2025

running conformance tests for @helia/verified-fetch results in the following error:

{
  "Time":"2025-02-11T09:07:30.674466-06:00",
  "Action":"output",
  "Package":"Gateway Tests",
  "Test":"TestTar/GET_TAR_with_format=tar_and_extract/Header_Etag",
  "Output":"        Error: Header 'Etag' expect to find substring 'W/\"bafkreialihlqnf5uwo4byh4n3cmwlntwqzxxs2fg5vanqdi3d7tb2l5xkm.x-tar', got '\"bafkreialihlqnf5uwo4byh4n3cmwlntwqzxxs2fg5vanqdi3d7tb2l5xkm.tar\"'\n"
}

However, there is no clarification on etag headers in the tar-response spec. We should link to

- Example: If TAR stream is generated by traversing an UnixFS directory in non-deterministic

Additional question(s):

  1. Should tar responses only include etag ending in x-tar, or only when it's a weak etag?
@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

1 participant