Venom: Test security event autoreg using DHCP fingerprint

[julsemaan]

Description

Test security event autoreg using DHCP fingerprint

Impacts

Venom tests

Delete branch after merge

YES

[julsemaan]

Pipeline: https://gitlab.com/inverse-inc/packetfence/-/pipelines/445856632

[nqb]

I re-run a pipeline and it works.

I will review this PR soon.

[nqb]

General remarks:

1. Can we merge this test suite to another scenario ? I'm thinking about captive_portal scenario
2. I think there is a risk that DHCP fingerprint can change when we will upgrade node01 OS or make some changes on infrastructure.
3. I think it could be interesting to check if security event has been triggered on node using API. Can be done later.
4. Could you add a short TESTSUITE.md which explain test suite ?

[julsemaan]

1. Can we merge this test suite to another scenario ? I'm thinking about captive_portal scenario

The "problem" with this is that since this suite involves switching from a VLAN to another it may break the other scenarios as they expand. Having one dedicated to security events (that would include isolation for suricata events, etc) made sense to me since it will be implicit that it involves multiple VLAN switches. I'm fine to merge it if you disagree, I'm just scared of the potential breakage that can happen due to it (either now or in the future)

2. I think there is a risk that DHCP fingerprint can change when we will upgrade node01 OS or make some changes on infrastructure.

It's a variable so we can always change it in the future when that happens. If I use dhcp_test, it won't be as "real" as using node01

3. I think it could be interesting to check if security event has been triggered on node using API. Can be done later.

👍

4. Could you add a short TESTSUITE.md which explain test suite ?

Will do

[nqb]

Agree with your answers @julsemaan.

[julsemaan]

PIpeline with fixes: https://gitlab.com/inverse-inc/packetfence/-/pipelines/456839663

[nqb]

LGTM.

I will just adjust syntax of variables to avoid spaces inside curly brackets like we have for all Venom test suites.

• Current: security_event_autoreg.node.mac: '{{ .node01_ens7_mac_address }}'
• Expected: security_event_autoreg.node.mac: '{{.node01_ens7_mac_address}}'