-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/debian installer #6803
Feature/debian installer #6803
Conversation
This still needs to be integrated in our release pipeline, I tested the ISO manually and I get through the configurator |
5018f98
to
f7b2b02
Compare
f7b2b02
to
a1c3df7
Compare
This should be ready, @nqb, can you review? You can download the ISO from here if you want to test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes but it looks good. I didn't test ZEN ISO.
General question: I compare preseed.cfg.tmpl
with preseed.cfg
used for ZEN. I see password is not set but I think it's to let user define it.
That is correct, since the install is interactive in this case, I'm letting users pick their own root password instead of having to change it post-install. I addressed your comments and rebuilt the ISO and tested it in my lab and it works. |
I tested ISO with success. I have one remaining comment: should we not disable predictable network names ? It's the case in ZEN image but it's more to simplify provisioning. However, I'm thinking about cluster installation where you can have different network names and you will need to disable it anyways. Option to add to preseed should be: 78f903e#diff-2e9669c2d68bf0daf463f91cf709f56da70b2ba792af71b0e5728f0f7ea7c670 |
We will need to update packetfence.org to mention new image and add a section in Installation guide. |
Could you disable AppArmor (like in ZEN image) ? I think you just need to add |
I noticed that the 'Graphical install' option ignores the preseed. I'm working on removing that option from the ISO too |
The downside with this is that all the network configuration you do during the installer is based on the 'non-predictable' interface name so when you boot into the OS, eth0 is down and not configured in /etc/network/interfaces. |
This was the issue we had with ZEN image. In that case, we can:
|
The installer accepts I retested an ISO and it works but haven't republished since I'd need to realter the .gitlab-ci file. I can provide an ISO to test if needed. Once we're happy with this, I'll write the steps in our install guide to get this installed |
Tested again, work as expected. |
Just did the instructions, went pretty generic so that it survives over time @extrafu, if you want to also check the instructions for verbiage and grammar |
Minor nits mentioned |
@nqb, all yours for the final review and merge |
Description
Adds tooling to create an ISO installer for PacketFence based on Debian 11.2
Impacts
Nothing, just adds tooling
Delete branch after merge
YES
Checklist
(REQUIRED) - [yes, no or n/a]