Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to LLVM 20 #6

Open
zanieb opened this issue Mar 6, 2025 · 5 comments
Open

Upgrade to LLVM 20 #6

zanieb opened this issue Mar 6, 2025 · 5 comments

Comments

@zanieb
Copy link

zanieb commented Mar 6, 2025

LLVM 20.1.0 was released a couple days ago https://github.com/llvm/llvm-project/releases/tag/llvmorg-20.1.0

We may want to include the following, which are not merged but are impactful for CPython performance:

@zanieb
Copy link
Author

zanieb commented Mar 8, 2025

There's a recommendation to merge and backport from a team member

I propose to merge llvm/llvm-project#114990 and backport it. This issue has already affected multiple projects, and Python is a widely used one. In fact, this PR just reverts the computed goto part of llvm/llvm-project#78582.

ref llvm/llvm-project#106846 (comment)

@indygreg
Copy link
Owner

indygreg commented Mar 8, 2025

I didn't realize the needed PRs aren't merged yet :/

I think I'm going to put out a vanilla LLVM 20 release then a variant with the unmerged patches.

@indygreg
Copy link
Owner

indygreg commented Mar 8, 2025

Actually, the patches don't look too bad. I'm pretty liberal in my tolerance for BOLT patches. And the LLVM codegen patch is pretty trivial. I'll probably just take them both and do 1 release.

@zanieb
Copy link
Author

zanieb commented Mar 8, 2025

Whatever you're more comfortable with.

@indygreg
Copy link
Owner

indygreg commented Mar 8, 2025

I've got CI runs in progress on the ci-test branch. (I don't bother with PRs in this repo.)

There's a bit of Actions Runners backlog due to other work in indygreg/python-zstandard.

Hopefully I'll get clean builds in ~3 hours. And if I'm around the computer later I should be able to publish a draft release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants