Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ".ts file extension" in README.md #114

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Update ".ts file extension" in README.md #114

merged 1 commit into from
Dec 27, 2024

Conversation

Alexander-Herranz
Copy link
Contributor

The README provides 2 commands to deploy contracts:

  1. npx hardhat run scripts/deploy_upgradeable.js
  2. npx hardhat run scripts/deploy_cloneable.js

But the mentioned files do not exist:

  • scripts/deploy_upgradeable.js
  • scripts/deploy_cloneable.js

And the correct files are:

  • scripts/deploy_upgradeable.ts
  • scripts/deploy_cloneable.ts

So correct command to deploy contracts are:
npx hardhat run scripts/deploy_upgradeable.js
npx hardhat run scripts/deploy_cloneable.js

@Chengxuan
Copy link
Contributor

Thanks for the correction! @Alexander-Herranz

@Chengxuan Chengxuan merged commit a737694 into hyperledger-labs:main Dec 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chengxuan Chengxuan Chengxuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexander-Herranz @Chengxuan