You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
panel==1.5.4
Python 3.10.4
Windows 10 Home 22H2 (64-bit)
bokeh==3.6.0
Chrome 130.0.6723.117 (64-bit)
Description of expected behavior and the observed behavior
When sending multiple notifications within the duration time of previous notification, I expect to see all notifications, one below another, vanishing one after the other.
What I get with Panel 1.5.4 is seeing multiple copies of the last notification (type and the message).
This is a regression, because I remember not having this problem before updating Panel. I thing that Panel 1.5.3 did not have this issue.
Complete, minimal, self-contained example code that reproduces the issue
I would expect to see warning notification with the "Warning" message above info notification with "Info" message, instead of seeing info notification with "Info" message twice.
I may be interested in making a pull request to address this
The text was updated successfully, but these errors were encountered:
Running git diff v1.3.8 v1.4.0 panel/io/notifications.py panel/io/state.py panel/config.py and checking the difference, it looks like it is caused by #6533.
The code to display notification regardless of whether it was send
before there was place to display it, or after it, was taken from
02-contributors_graph.py. Some minor changes had to be made for
it to work as intended (i.e. the warning should be shown on each
reload).
The check was manual, and not automatic, done by running the app
and seeing if the warning will appear.
.
NOTE that `panel serve` runs with files from source, not from installed
package; that is why diffinsights_web/apps/contributors.py requires
absolute imports, while we could use relative imports in diffannotator/*.py
scripts.
.
By the way, it turns out that there is regression in Panel 1.5.4
in regards to notifications, detected when testing this change:
holoviz/panel#7504
ALL software version info
Software Version Info
Description of expected behavior and the observed behavior
When sending multiple notifications within the duration time of previous notification, I expect to see all notifications, one below another, vanishing one after the other.
What I get with Panel 1.5.4 is seeing multiple copies of the last notification (type and the message).
This is a regression, because I remember not having this problem before updating Panel. I thing that Panel 1.5.3 did not have this issue.
Complete, minimal, self-contained example code that reproduces the issue
Screenshots or screencasts of the bug in action
I would expect to see warning notification with the "Warning" message above info notification with "Info" message, instead of seeing info notification with "Info" message twice.
The text was updated successfully, but these errors were encountered: