Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reactive updates to override constant parameters #5032

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

philippjfr
Copy link
Member

Fixes #5030

@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #5032 (3d93540) into main (480e6b0) will increase coverage by 9.89%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #5032      +/-   ##
==========================================
+ Coverage   73.40%   83.29%   +9.89%     
==========================================
  Files         271      271              
  Lines       38361    38363       +2     
==========================================
+ Hits        28157    31956    +3799     
+ Misses      10204     6407    -3797     
Flag Coverage Δ
ui-tests 39.80% <20.00%> (?)
unitexamples-tests 73.39% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/base.py 86.25% <50.00%> (+0.07%) ⬆️
panel/io/convert.py 72.18% <100.00%> (+46.99%) ⬆️

... and 51 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr force-pushed the reactive_constant_update branch from 8ffa3dd to 3d93540 Compare June 4, 2023 16:27
@philippjfr philippjfr merged commit ea46b55 into main Jun 4, 2023
@philippjfr philippjfr deleted the reactive_constant_update branch June 4, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior with TypeError: Constant parameter 'value_throttled' cannot be modified
1 participant