Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of single and empty options on DiscreteSlider #3297

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 1, 2022

Fixes #1804
Fixes #2394
Fixes #2395

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #3297 (03b5e15) into master (7810c1e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
+ Coverage   83.38%   83.41%   +0.03%     
==========================================
  Files         195      195              
  Lines       26387    26423      +36     
==========================================
+ Hits        22003    22041      +38     
+ Misses       4384     4382       -2     
Impacted Files Coverage Δ
panel/tests/widgets/test_slider.py 100.00% <100.00%> (ø)
panel/widgets/slider.py 84.85% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7810c1e...03b5e15. Read the comment docs.

@philippjfr philippjfr merged commit 070b0c4 into master Apr 1, 2022
@philippjfr philippjfr deleted the discrete_slider_options branch April 1, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant