Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python2 compatibility #225

Merged
merged 11 commits into from
Jan 28, 2019
Merged

Python2 compatibility #225

merged 11 commits into from
Jan 28, 2019

Conversation

philippjfr
Copy link
Member

No description provided.

jbednar
jbednar approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad there weren't more changes needed, if we haven't been running python2 tests!!!

@philippjfr philippjfr force-pushed the py2 branch 2 times, most recently from 84eecee to be3296d Compare January 28, 2019 16:22
@philippjfr
Copy link
Member Author

I'm glad there weren't more changes needed, if we haven't been running python2 tests!!!

Bit premature but I think I've got it now.

@philippjfr philippjfr merged commit 0046e0b into master Jan 28, 2019
@fmaussion
Copy link

Devil's advocate here. Was this really necessary? Xarray just merged a PR to remove py2 compat ;-)

@philippjfr
Copy link
Member Author

After going through all the effort I'd be very tempted to say no, but we'll probably drop py2 compatibility for all projects at the same time.

@fmaussion
Copy link

Related: https://twitter.com/mrocklin/status/1083889299211223040

"Here's a new one. The Dask-Kubernetes subproject just accepted a patch to support Python 2 (Dask's Kubernetes was Python 3 only), then cut a release, and immediately dropped Python 2 again."

@jbednar
Copy link
Member

jbednar commented Jan 28, 2019

Panel replaces ParamNB and ParamBokeh, which both supported Python2, and I don't want people ever to have any reason to turn to those older projects. When we drop Python2 support in Panel (which we will!), we can now safely point people who are stuck on py2 to use an older Panel release, rather than having them pointlessly invest in ParamNB or ParamBokeh.

@jbednar jbednar deleted the py2 branch January 28, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philippjfr @fmaussion @jbednar