-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpeechToText Widget #1880
SpeechToText Widget #1880
Conversation
The Reference Notebook is now ready for review. I identified some bugs and fixed them while developing. I hope to develop an example for the Gallery to further learn about and test the widget. |
FYI. @philippjfr I have finalized the implementation and testing. This includes adding an additional notebook to the Gallery. I don't plan to do anything more on this before I get feedback from review or users. |
The gallery notebook is "demoed" here https://discourse.holoviz.org/t/texttospeech-example-pr/1646 |
Three comments:
|
525f02c
to
f4cf99d
Compare
…o speech-to-text
Regarding the 3 flake "line too long errors" they do not make sense. As you can see below the line is NOT too long. Thus there is nothing I can fix. @philippjfr |
I've fixed what I can fix (see flake comment above). I have run
My hypothesis is that it has nothing to do with this PR. Next step is on you @philippjfr . Let me know if there is more I can/ shall do? |
Thanks, I'll take a look. |
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
==========================================
- Coverage 85.21% 84.87% -0.35%
==========================================
Files 152 157 +5
Lines 18981 19360 +379
==========================================
+ Hits 16175 16432 +257
- Misses 2806 2928 +122
Continue to review full report at Codecov.
|
Thanks @MarcSkovMadsen! |
Preliminary SpeechToTextWidget.
I've implemented, test and created parts of a Notebook. The functionality seems to be there.
But I need to learn and improve from some more advanced examples. And finalize the notebook.
The PR is showcased here https://discourse.holoviz.org/t/happy-new-year-w-speechtotext-widget-pr/1637. This includes a video of it.
FYI. @philippjfr