From 9dc4d81de2bbf8e74a1340bd2875275ee979da5b Mon Sep 17 00:00:00 2001 From: Jason Kuhrt Date: Sat, 23 Mar 2024 08:37:34 -0400 Subject: [PATCH] refactor: tidy signature --- examples/request-cancellation.ts | 7 +++---- src/legacy/classes/GraphQLClient.ts | 10 +++------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/examples/request-cancellation.ts b/examples/request-cancellation.ts index 337ecac83..b9df5fde5 100644 --- a/examples/request-cancellation.ts +++ b/examples/request-cancellation.ts @@ -17,9 +17,7 @@ const endpoint = `https://api.graph.cool/simple/v1/cixos23120m0n0173veiiwrjr` signal: abortController.signal, }) - // todo - // eslint-disable-next-line - client.request(gql` + void client.request(gql` { Movie(title: "Inception") { releaseDate @@ -51,9 +49,10 @@ const endpoint = `https://api.graph.cool/simple/v1/cixos23120m0n0173veiiwrjr` } } ` - const _requesting = client.request({ + void client.request({ document, signal: abortController.signal, }) + abortController.abort() } diff --git a/src/legacy/classes/GraphQLClient.ts b/src/legacy/classes/GraphQLClient.ts index fc83974c5..58ff18ee5 100644 --- a/src/legacy/classes/GraphQLClient.ts +++ b/src/legacy/classes/GraphQLClient.ts @@ -88,13 +88,9 @@ export class GraphQLClient { /** * Send a GraphQL document to the server. */ - async request( - document: RequestDocument | TypedDocumentNode, - ...variablesAndRequestHeaders: VariablesAndRequestHeadersArgs - ): Promise - async request( - options: RequestOptions, - ): Promise + // dprint-ignore + async request(document: RequestDocument | TypedDocumentNode, ...variablesAndRequestHeaders: VariablesAndRequestHeadersArgs): Promise + async request(options: RequestOptions): Promise async request( documentOrOptions: | RequestDocument