Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax bounds on FromBytes for MaybeUninit<T>? #310

Closed
joshlf opened this issue Sep 2, 2023 · 1 comment
Closed

Relax bounds on FromBytes for MaybeUninit<T>? #310

joshlf opened this issue Sep 2, 2023 · 1 comment
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking

Comments

@joshlf
Copy link
Member

joshlf commented Sep 2, 2023 •
edited
Loading

Currently, in order for MaybeUninit<T>: FromBytes, we require that T: FromBytes. This was introduced in #308 to deal with the soundness hole described in #299. However, we could relax the bound from T: FromBytes to T: FromZeroes and it would still be sound. It's a bit "asymmetrical", but it's strictly more permissive, so maybe we should do it?

If we eventually implement #251, we should just relax these bounds to NoCell.
@joshlf joshlf added the compatibility-nonbreaking Changes that are (likely to be) non-breaking label Sep 2, 2023
@joshlf
Copy link
Member Author

joshlf commented May 3, 2024

Closed in #682

@joshlf joshlf closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshlf