From 6dda7be0e847e5fc140600fdef77f95ce354063b Mon Sep 17 00:00:00 2001 From: KW86022 <184099420+KW86022@users.noreply.github.com> Date: Thu, 17 Oct 2024 14:09:21 +0000 Subject: [PATCH 1/9] Intial removal of legacyBehaviour from next js links --- frontend/pages/help.tsx | 4 ++-- frontend/src/Link.tsx | 5 +---- frontend/src/docs/DocsWrapper.tsx | 4 ++-- frontend/src/docs/IntroCard.tsx | 2 +- 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/frontend/pages/help.tsx b/frontend/pages/help.tsx index 6c755c217..f5f202a6c 100644 --- a/frontend/pages/help.tsx +++ b/frontend/pages/help.tsx @@ -69,8 +69,8 @@ export default function Help() { To find out more about Bailo please see our documentation pages. - - + + diff --git a/frontend/src/Link.tsx b/frontend/src/Link.tsx index 6bfe03eff..7a0167248 100644 --- a/frontend/src/Link.tsx +++ b/frontend/src/Link.tsx @@ -17,7 +17,7 @@ interface NextLinkComposedProps export const NextLinkComposed = forwardRef( function NextLinkComposed(props, ref) { - const { to, linkAs, replace, scroll, shallow, prefetch, legacyBehavior = true, locale, ...other } = props + const { to, linkAs, replace, scroll, shallow, prefetch, locale, ...other } = props return ( @@ -54,7 +53,6 @@ const Link = forwardRef(function Link(props, ref) as, className: classNameProps, href, - legacyBehavior, linkAs: linkAsProp, locale, noLinkStyle, @@ -90,7 +88,6 @@ const Link = forwardRef(function Link(props, ref) scroll, shallow, prefetch, - legacyBehavior, locale, } diff --git a/frontend/src/docs/DocsWrapper.tsx b/frontend/src/docs/DocsWrapper.tsx index ff06d440d..88988cd02 100644 --- a/frontend/src/docs/DocsWrapper.tsx +++ b/frontend/src/docs/DocsWrapper.tsx @@ -65,7 +65,7 @@ export default function DocsWrapper({ children }: DocsWrapperProps): ReactElemen ) : ( - + - + From 43da703acb1c8c32a0aafe20e29e639c9c23d706 Mon Sep 17 00:00:00 2001 From: KW86022 <184099420+KW86022@users.noreply.github.com> Date: Tue, 22 Oct 2024 10:44:12 +0000 Subject: [PATCH 2/9] codemod --- .husky/pre-commit | 4 ---- frontend/pages/help.tsx | 2 +- frontend/src/Link.tsx | 1 + frontend/src/docs/DocsWrapper.tsx | 2 +- frontend/src/docs/IntroCard.tsx | 2 +- frontend/src/marketplace/EntryList.tsx | 2 +- 6 files changed, 5 insertions(+), 8 deletions(-) delete mode 100755 .husky/pre-commit diff --git a/.husky/pre-commit b/.husky/pre-commit deleted file mode 100755 index d24fdfc60..000000000 --- a/.husky/pre-commit +++ /dev/null @@ -1,4 +0,0 @@ -#!/usr/bin/env sh -. "$(dirname -- "$0")/_/husky.sh" - -npx lint-staged diff --git a/frontend/pages/help.tsx b/frontend/pages/help.tsx index f5f202a6c..b3b418d95 100644 --- a/frontend/pages/help.tsx +++ b/frontend/pages/help.tsx @@ -70,7 +70,7 @@ export default function Help() { - + diff --git a/frontend/src/Link.tsx b/frontend/src/Link.tsx index 7a0167248..6748a460d 100644 --- a/frontend/src/Link.tsx +++ b/frontend/src/Link.tsx @@ -29,6 +29,7 @@ export const NextLinkComposed = forwardRef diff --git a/frontend/src/docs/DocsWrapper.tsx b/frontend/src/docs/DocsWrapper.tsx index 88988cd02..d79b629e6 100644 --- a/frontend/src/docs/DocsWrapper.tsx +++ b/frontend/src/docs/DocsWrapper.tsx @@ -65,7 +65,7 @@ export default function DocsWrapper({ children }: DocsWrapperProps): ReactElemen ) : ( - + - + diff --git a/frontend/src/marketplace/EntryList.tsx b/frontend/src/marketplace/EntryList.tsx index 383cac9b9..c6a96c503 100644 --- a/frontend/src/marketplace/EntryList.tsx +++ b/frontend/src/marketplace/EntryList.tsx @@ -26,7 +26,7 @@ export default function EntryList({ return entries.map((entry, index) => ( - + {entry.name} From 4308419832f51fad15d5cb03e972ffed6469df72 Mon Sep 17 00:00:00 2001 From: KW86022 <184099420+KW86022@users.noreply.github.com> Date: Tue, 22 Oct 2024 11:09:26 +0000 Subject: [PATCH 3/9] revert changes Revert "revert changes" This reverts commit 55613efbddf5784b0f42bb60976ec723b6a813b8. From ae1829992c904f23ba2358e70c87225d9e90b082 Mon Sep 17 00:00:00 2001 From: KW86022 <184099420+KW86022@users.noreply.github.com> Date: Tue, 22 Oct 2024 11:14:04 +0000 Subject: [PATCH 4/9] remove legacy behavior from EntryList --- frontend/src/marketplace/EntryList.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/marketplace/EntryList.tsx b/frontend/src/marketplace/EntryList.tsx index c6a96c503..383cac9b9 100644 --- a/frontend/src/marketplace/EntryList.tsx +++ b/frontend/src/marketplace/EntryList.tsx @@ -26,7 +26,7 @@ export default function EntryList({ return entries.map((entry, index) => ( - + {entry.name} From 76b9a2e05bc7da8dde0eff6c321762a852845bf1 Mon Sep 17 00:00:00 2001 From: KW86022 <184099420+KW86022@users.noreply.github.com> Date: Tue, 22 Oct 2024 11:21:17 +0000 Subject: [PATCH 5/9] All legacy behaviour removed except for custom link --- frontend/pages/help.tsx | 2 +- frontend/src/docs/DocsWrapper.tsx | 4 ++-- frontend/src/docs/IntroCard.tsx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frontend/pages/help.tsx b/frontend/pages/help.tsx index b3b418d95..f5f202a6c 100644 --- a/frontend/pages/help.tsx +++ b/frontend/pages/help.tsx @@ -70,7 +70,7 @@ export default function Help() { - + diff --git a/frontend/src/docs/DocsWrapper.tsx b/frontend/src/docs/DocsWrapper.tsx index d79b629e6..b4f4dd32c 100644 --- a/frontend/src/docs/DocsWrapper.tsx +++ b/frontend/src/docs/DocsWrapper.tsx @@ -65,7 +65,7 @@ export default function DocsWrapper({ children }: DocsWrapperProps): ReactElemen ) : ( - + - + From 4ff6571567e1cfc50cfe6e682d784d9decf03b54 Mon Sep 17 00:00:00 2001 From: KW86022 <184099420+KW86022@users.noreply.github.com> Date: Tue, 22 Oct 2024 11:24:58 +0000 Subject: [PATCH 6/9] remove legacy behaviour in custom link --- frontend/src/Link.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/Link.tsx b/frontend/src/Link.tsx index 6748a460d..29076f57b 100644 --- a/frontend/src/Link.tsx +++ b/frontend/src/Link.tsx @@ -29,9 +29,9 @@ export const NextLinkComposed = forwardRef - + {props.children} ) }, From b3050972078220d84588322da9df24cf86f61868 Mon Sep 17 00:00:00 2001 From: KW86022 <184099420+KW86022@users.noreply.github.com> Date: Tue, 22 Oct 2024 12:11:49 +0000 Subject: [PATCH 7/9] add the file --- .husky/pre-commit | 4 ++++ 1 file changed, 4 insertions(+) create mode 100755 .husky/pre-commit diff --git a/.husky/pre-commit b/.husky/pre-commit new file mode 100755 index 000000000..d24fdfc60 --- /dev/null +++ b/.husky/pre-commit @@ -0,0 +1,4 @@ +#!/usr/bin/env sh +. "$(dirname -- "$0")/_/husky.sh" + +npx lint-staged From a264af5c22972c11c89bdf38e315d60863a0b580 Mon Sep 17 00:00:00 2001 From: KW86022 <184099420+KW86022@users.noreply.github.com> Date: Tue, 22 Oct 2024 12:24:54 +0000 Subject: [PATCH 8/9] changed link to inherit colour --- frontend/src/docs/DocsWrapper.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frontend/src/docs/DocsWrapper.tsx b/frontend/src/docs/DocsWrapper.tsx index b4f4dd32c..0c972da23 100644 --- a/frontend/src/docs/DocsWrapper.tsx +++ b/frontend/src/docs/DocsWrapper.tsx @@ -65,7 +65,7 @@ export default function DocsWrapper({ children }: DocsWrapperProps): ReactElemen ) : ( - + Date: Tue, 22 Oct 2024 20:53:37 +0000 Subject: [PATCH 9/9] ensure ref is still passed down --- frontend/src/Link.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/frontend/src/Link.tsx b/frontend/src/Link.tsx index 29076f57b..40ef297d8 100644 --- a/frontend/src/Link.tsx +++ b/frontend/src/Link.tsx @@ -29,6 +29,7 @@ export const NextLinkComposed = forwardRef {props.children}