Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter while browsing #1910

Open
cassidyjames opened this issue Sep 7, 2023 · 9 comments
Open

Filter while browsing #1910

cassidyjames opened this issue Sep 7, 2023 · 9 comments

Comments

@cassidyjames
Copy link
Contributor

Right now it looks like filters like the FOSS filter only show up on the search results page. It would be nice to be able to browse using the filters as well, e.g. if you only want to explore FOSS apps.

@ssokolow
Copy link

Agreed. I hadn't even realized filtering had been implemented because my primary interaction with Flathub is to visit https://flathub.org/apps/collection/recently-added/ every so often to see if any more of the apps I use have been "made easier to custom-sandbox than Firejail" yet.

@cahfofpai
Copy link

Any progress on this issue?

@cahfofpai
Copy link

@cassidyjames Do you or somebody else plan to implement it, or would it be open for anybody to work on?

@razzeee
Copy link
Member

razzeee commented Oct 21, 2024

I mostly see problems with this. Tthis might lead to empty pages/sections, without users understanding why that is.

@cahfofpai
Copy link

I mostly see problems with this. Tthis might lead to empty pages/sections, without users understanding why that is.

An empty state could be implemented for cases like this, which informs the users about the global filter being applied leading to the empty page / section.

@cahfofpai
Copy link

Would it be relevant to take server load into consideration for this feature?
Because when using the global filter, a search query would be necessary for every page call to filter the apps to be displayed.
Would the additional load be manageable with the current server setup?

@razzeee
Copy link
Member

razzeee commented Oct 27, 2024

We generate static pages on demand, so it shouldn't be too bad, but the more mutations there are, the slower will our page be.

@cahfofpai
Copy link

Would you generate static pages for all combinations of filter criteria?
Categories could be left out as it does not make sense as global filter. But if all of the other filter criteria would be allowed for the global filter, there would be nonetheless many combinations:
3 (License) * 3 (Verification) * 3 (App Type) * 3 (Arch) = 81 possible combinations
(for a criteria with 2 choices there are 3 options, as it is optional and thus could also be left blank)

@razzeee
Copy link
Member

razzeee commented Oct 27, 2024

x number of translations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants