Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate experimental-peer-skip-client-san-verification flag to peer-skip-client-san-verification #19062

Closed
siyuanfoundation opened this issue Dec 13, 2024 · 5 comments · Fixed by #19362
Closed

migrate experimental-peer-skip-client-san-verification flag to peer-skip-client-san-verification #19062

siyuanfoundation opened this issue Dec 13, 2024 · 5 comments · Fixed by #19362
Assignees
@wodeyoulai @7h3-3mp7y-m4n
Labels
good first issue help wanted type/feature

Comments

@siyuanfoundation
Copy link
Contributor

What would you like to be added?

Migrate --experimental-peer-skip-client-san-verification flag to use feature gate

Example for migrating an experimental flag: #18478

Why is this needed?

part of #18023
@siyuanfoundation siyuanfoundation mentioned this issue Dec 13, 2024
Open
15 tasks
@7h3-3mp7y-m4n
Copy link

Hey, can I pick this? Thanks!

@siyuanfoundation
Copy link
Contributor Author

/assign @7h3-3mp7y-m4n
Thank you!

@wodeyoulai wodeyoulai mentioned this issue Jan 17, 2025
Closed
@wodeyoulai
Copy link
Contributor

@7h3-3mp7y-m4n @siyuanfoundation I've submitted a PR #19225 to address this issue.

@7h3-3mp7y-m4n
Copy link

that's good, you can take this! @wodeyoulai

@siyuanfoundation
Copy link
Contributor Author

/assign @wodeyoulai

@siyuanfoundation siyuanfoundation mentioned this issue Feb 7, 2025
Merged
@siyuanfoundation siyuanfoundation changed the title migrate experimental-peer-skip-client-san-verification flag to feature gate migrate experimental-peer-skip-client-san-verification flag to peer-skip-client-san-verification Feb 7, 2025
@siyuanfoundation siyuanfoundation mentioned this issue Feb 7, 2025
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wodeyoulai wodeyoulai

@7h3-3mp7y-m4n 7h3-3mp7y-m4n

Labels
good first issue help wanted type/feature
Milestone
No milestone
3 participants
@siyuanfoundation @wodeyoulai @7h3-3mp7y-m4n