Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSRV check #3207

Closed
MabezDev opened this issue Mar 4, 2025 · 5 comments
Closed

Fix MSRV check #3207

MabezDev opened this issue Mar 4, 2025 · 5 comments
Labels
CI Continuous integration/deployment
Milestone
1.0.0-beta.1

Comments

@MabezDev
Copy link
Member

MabezDev commented Mar 4, 2025

It's currently failing because we need to manage changing toolchain version (as we now run these tests on the self hosted runners). Example job failure: https://github.com/esp-rs/esp-hal/actions/runs/13655133548/job/38172360501?pr=3200
@MabezDev MabezDev added the CI Continuous integration/deployment label Mar 4, 2025
@MabezDev MabezDev added this to the 1.0.0-beta.1 milestone Mar 4, 2025
@github-project-automation github-project-automation bot moved this to Todo in esp-rs Mar 4, 2025
@bugadani
Copy link
Contributor

bugadani commented Mar 4, 2025

Should be fixed by esp-rs/espup#481 ?

@MabezDev
Copy link
Member Author

MabezDev commented Mar 4, 2025

Ah, so we need an espup & xtensa-toolchain release, is that right @SergioGasquez?

@SergioGasquez
Copy link
Member

We only need an espup release, will prepare it!

@SergioGasquez
Copy link
Member

[email protected] is now published and I just rerun the msrv check action and now the xtensa-toolchain succeeds https://github.com/esp-rs/esp-hal/actions/runs/13655133548/job/38177931148?pr=3200

@MabezDev
Copy link
Member Author

MabezDev commented Mar 4, 2025

Thanks!

@MabezDev MabezDev closed this as completed Mar 4, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous integration/deployment
Projects
esp-rs
Archived in project
Milestone
1.0.0-beta.1
Development

No branches or pull requests
3 participants
@bugadani @MabezDev @SergioGasquez