OpenDrain functionality seems to be broken since 1.0.0-beta.0

[bjoernQ]

We removed the explicit OpenDrainOutput driver in favor of a config on Output (and making it into Flex)

Working with the OpenDrainOutput driver on 0.23.1 (connect the two pins)

    let mut a = OutputOpenDrain::new(peripherals.GPIO6, Level::High, Pull::Up);
    let mut b = OutputOpenDrain::new(peripherals.GPIO7, Level::High, Pull::Up);

    let delay = Delay::new();

    loop {
        println!("high/high");
        a.set_high();
        b.set_high();
        delay.delay_millis(5);
        println!("{} {}", a.is_high(), b.is_high());

        println!("low/high");
        a.set_low();
        b.set_high();
        delay.delay_millis(5);
        println!("{} {}", a.is_high(), b.is_high());

        println!("high/low");
        a.set_high();
        b.set_low();
        delay.delay_millis(5);
        println!("{} {}", a.is_high(), b.is_high());

        println!("low/low");
        a.set_low();
        b.set_low();
        delay.delay_millis(5);
        println!("{} {}", a.is_high(), b.is_high());

        println!();
    }

Non-working on 1.0.0-beta.0 (connect the two pins)

    let mut a = Output::new(
        peripherals.GPIO6,
        Level::High,
        OutputConfig::default()
            .with_drive_mode(DriveMode::OpenDrain)
            .with_pull(Pull::Up),
    )
    .into_flex();
    let mut b = Output::new(
        peripherals.GPIO7,
        Level::High,
        OutputConfig::default()
            .with_drive_mode(DriveMode::OpenDrain)
            .with_pull(Pull::Up),
    )
    .into_flex();

    let delay = Delay::new();

    loop {
        println!("high/high");
        a.set_high();
        b.set_high();
        delay.delay_millis(5);
        println!("{} {}", a.is_high(), b.is_high());

        println!("low/high");
        a.set_low();
        b.set_high();
        delay.delay_millis(5);
        println!("{} {}", a.is_high(), b.is_high());

        println!("high/low");
        a.set_high();
        b.set_low();
        delay.delay_millis(5);
        println!("{} {}", a.is_high(), b.is_high());

        println!("low/low");
        a.set_low();
        b.set_low();
        delay.delay_millis(5);
        println!("{} {}", a.is_high(), b.is_high());

        println!();
    }

In 1.0.0-beta.0 we never read a high level

[MabezDev]

There seems to be a difference in how to set the pin into open drain before #3029, we used to call set_to_open_drain_output now we just set the w.pad_driver() bit in apply_config instead. I suppose set_to_open_drain_output was doing something we're not doing now. Alternatively the order of operations could matter here.

[bjoernQ]

I think we can solve it with just some documentation (i.e. an additional step is needed to regain the full functionality of OpenDrainOutput) - let me see

[bjoernQ]

Yes - no code changes needed

[bugadani]

In 1.0.0-beta.0 we never read a high level

Huh did I forget to remove the readback functions?

[MabezDev]

In 1.0.0-beta.0 we never read a high level

Huh did I forget to remove the readback functions?

The output is read once it's turned into Flex, so you didn't forget anything.