Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPI: Driver structs don't derive PartialEq/Eq #2791

Closed
Tracked by #2494
bjoernQ opened this issue Dec 13, 2024 · 1 comment · Fixed by #2823
Closed
Tracked by #2494

SPI: Driver structs don't derive PartialEq/Eq #2791

bjoernQ opened this issue Dec 13, 2024 · 1 comment · Fixed by #2823
Assignees
@bugadani
Labels
1.0-blocker peripheral:spi SPI peripheral
Milestone
0.23.0

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 13, 2024

No description provided.

@bjoernQ bjoernQ mentioned this issue Dec 13, 2024
Open
41 tasks
@bjoernQ bjoernQ changed the title Driver structs don't derive PartialEq/Eq SPI: Driver structs don't derive PartialEq/Eq Dec 13, 2024
@MabezDev MabezDev added this to the 1.0.0-beta.0 milestone Dec 17, 2024
@bugadani bugadani self-assigned this Dec 17, 2024
@bugadani bugadani mentioned this issue Dec 17, 2024
Merged
@bugadani
Copy link
Contributor

Actually, this was closed by #2832 - we don't currently want to implement PartialEq/Eq for driver structs.

@bugadani bugadani closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bugadani bugadani

Labels
1.0-blocker peripheral:spi SPI peripheral
Projects
esp-rs
Archived in project
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

SPI: Implement missing traits bugadani/esp-hal
3 participants
@bugadani @bjoernQ @MabezDev