Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing https://docs.rs/embedded-hal/1.0.0/embedded_hal/spi/trait.SpiDevice.html impl #2778

Open
Tracked by #2494
bjoernQ opened this issue Dec 13, 2024 · 4 comments
Labels
1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. peripheral:spi SPI peripheral

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 13, 2024

  • Something like embassy-hal spi bus has
  • Related to hardware cs management item below
  • Note from danielb: device shouldn't be implemented for bus driver structs.
@tom-borcin tom-borcin added the investigation Not needed for 1.0, but don't know if we can support without breaking the driver. label Dec 16, 2024
@jessebraham
Copy link
Member

Adding a new third-party trait implementation shouldn't be a breaking change, should it? Don't recall why we decided to implement this, it should be additive functionality AFAIK. Am I missing/forgetting something?

@bugadani
Copy link
Contributor

I think this is in "investigation" because I'm stubbornly keep repeating that the SPI bus drivers we have should not implement SpiDevice anyway, and that deserved the investigation label instead of a 10-minute detour.

@bugadani
Copy link
Contributor

FWIW the resolution of this issue is still just adding more code so the 1.0-blocker can probably be removed.

@MabezDev
Copy link
Member

MabezDev commented Jan 8, 2025

Agree, we can add this post 1.0 as it will be a completely new set of structs.

@MabezDev MabezDev added 1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. and removed 1.0-blocker investigation Not needed for 1.0, but don't know if we can support without breaking the driver. labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 non-breaking Not needed for 1.0 and can be supported without breaking the driver. peripheral:spi SPI peripheral
Projects
Status: Todo
Development

No branches or pull requests

5 participants