Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builders should annotate the setters with #[must_use] #2745

Closed
bjoernQ opened this issue Dec 12, 2024 · 0 comments · Fixed by #2841
Closed

Builders should annotate the setters with #[must_use] #2745

bjoernQ opened this issue Dec 12, 2024 · 0 comments · Fixed by #2841
Assignees
@jessebraham
Labels
1.0-blocker bug Something isn't working status:needs-attention This should be prioritized

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 12, 2024

I have seen user code like this:

let cfg = esp_hal::uart::Config::default();
cfg.baudrate(9600);

Annotating the setters with #[must_use] should help
@bjoernQ bjoernQ added the status:needs-attention This should be prioritized label Dec 12, 2024
@bugadani bugadani added the bug Something isn't working label Dec 12, 2024
@bugadani bugadani mentioned this issue Dec 13, 2024
Open
@jessebraham jessebraham self-assigned this Dec 19, 2024
@jessebraham jessebraham mentioned this issue Dec 19, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessebraham jessebraham

Labels
1.0-blocker bug Something isn't working status:needs-attention This should be prioritized
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Annotate builder functions with #[must_use] jessebraham/esp-hal
4 participants
@bugadani @jessebraham @bjoernQ @MabezDev