Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check usage of unwrap / panic #2657

Closed
bjoernQ opened this issue Dec 2, 2024 · 1 comment
Closed

Double check usage of unwrap / panic #2657

bjoernQ opened this issue Dec 2, 2024 · 1 comment
Labels
1.0-blocker investigation Not needed for 1.0, but don't know if we can support without breaking the driver. peripheral:gpio GPIO peripheral

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Dec 2, 2024

  • There are two unwraps - one can never fail the other could (set_interrupt_priority)

  • There are a few explicit panics which are inevitable but maybe we should document it

@github-project-automation github-project-automation bot moved this to Todo in esp-rs Dec 2, 2024
@MabezDev MabezDev mentioned this issue Dec 4, 2024
34 tasks
@tom-borcin tom-borcin added the investigation Not needed for 1.0, but don't know if we can support without breaking the driver. label Dec 18, 2024
@MabezDev
Copy link
Member

MabezDev commented Jan 8, 2025

I think this is dupe of #2710 and #2760

@MabezDev MabezDev closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0-blocker investigation Not needed for 1.0, but don't know if we can support without breaking the driver. peripheral:gpio GPIO peripheral
Projects
Archived in project
Development

No branches or pull requests

3 participants