Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we include some very common crates as dependencies by default? #51

Closed
bjoernQ opened this issue Nov 21, 2024 · 2 comments
Closed

Comments

@bjoernQ
Copy link
Collaborator

bjoernQ commented Nov 21, 2024

While not needed to build the generated code some crates are very common to use - maybe it would be convenient to always have them already included

Currently only critical-section comes to my mind but probably there is more?

@bjoernQ bjoernQ mentioned this issue Nov 26, 2024
@bjoernQ
Copy link
Collaborator Author

bjoernQ commented Nov 26, 2024

I added critical-section in #60 - if anyone identifies more common dependencies we can collect them here - otherwise we can close this at some point in time

@MabezDev
Copy link
Member

MabezDev commented Feb 4, 2025

I think we want to add the deps that are needed for the template as it means we'll have to keep updating those too. I suppose stable crates like critical-section are fine.

Closing.

@MabezDev MabezDev closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants