Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D Viewer allows structure manipulation in View only mode #5582

Closed
Zhirnoff opened this issue Sep 25, 2024 · 1 comment · Fixed by #5608
Closed

3D Viewer allows structure manipulation in View only mode #5582

Zhirnoff opened this issue Sep 25, 2024 · 1 comment · Fixed by #5608
Assignees
@daniil-sloboda
Labels
MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Milestone
Ketcher 2.26.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open a structure in Ketcher.
  2. Switch to "View Only" mode. ketcher.editor.options({ viewOnlyMode: true })
  3. Activate the "3D Viewer"
  4. Attempt to manipulate the structure using the 3D Viewer and press Apply button.

Actual behavior
Through the "3D View" interface, user can still change position of the structure on canvas, which contradicts intended functionality of "View Only" mode

Expected behavior
The 3D View should allow manipulation of the structure in "View Only" mode but button Apply should be disabled.

Screenshots
2024-09-25_12h02_00

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.4]
Indigo version
[Version 1.24.0-rc.3]
Bug found during testing: #4965
@Zhirnoff Zhirnoff added bug Priority: Medium MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Sep 25, 2024
@daniil-sloboda daniil-sloboda linked a pull request Sep 30, 2024 that will close this issue
#5296 - Save Support for RDF Format #5608
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Oct 8, 2024

Tested. Bug fixed.
2024-10-08_14h44_27

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.1]
Indigo version
[Version 1.25.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniil-sloboda daniil-sloboda

Labels
MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Priority: Medium
Projects
None yet
Milestone
Ketcher 2.26.0-rc.1
Development

Successfully merging a pull request may close this issue.

#5296 - Save Support for RDF Format epam/ketcher
2 participants
@Zhirnoff @daniil-sloboda