Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reaction layout #2243

Closed
ljubica-milovic opened this issue Jul 23, 2024 · 2 comments
Closed

Improve reaction layout #2243

ljubica-milovic opened this issue Jul 23, 2024 · 2 comments

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jul 23, 2024

Steps to Reproduce

  1. Go to Ketcher micromolecules mode
  2. Load this file: Layout1.zip
  3. Click Layout (Ctrl+L)
  4. Load this file: Layout2.zip
  5. Click Layout (Ctrl+L)
  6. Load this file: Layout3.zip
  7. Click Layout (Ctrl+L)

Actual behavior
3.
image
image
5.
image
image
7.
image
image

Expected behavior
All elements of the reaction - reactants (chemicals on the left side of the arrow), products (chemicals of the right side of the arrow), pluses, arrows, and additional context above/bellow (text/chemical structure) the arrow should be arranged appropriately:

  • Every element should be placed in a cell with determined margins (The table is not visible to the user) (related issue #5152)
  • The height of all cells is height of the tallest structure (the tallest structure cannot be the arrow and additional context above/bellow the arrow);
  • The width of every cell is the width of the element in the cell + 2 * margin;
  • Every element (except arrows and additional context above/bellow the arrow) should be centered in its cell (a midline passes thought the vertical middle of elements);
  • The arrow (and the additional context above/bellow the arrow) should be placed such that the arrow is aligned with the midline;
  • The arrow size should be changed to default arrow size if possible;
  • If the width of the additional context above/bellow the arrow + 2 * margin > default arrow size the size of the arrow should be adjusted to additional context above/bellow the arrow + 2 * margin;
  • Additional context bellow/above the arrow should be placed one margin away from the arrow in the center;
    (images for better understanding)
    image
    image

Ketcher version [v2.23.0]

@accmeboot
Copy link

@AlekseiKhariukov
Shouldn't it be indigo task?

@AnnaKosol
Copy link
Collaborator

This task resolved by #2176
Image
Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants