Set ownerReference on gateway Deployment

[JuniorJPDJ]

Description:
Would be cool to see Deployment created for Gateway to have ownerReference for Gateway.
This allows following chain and for example makes ArgoCD show the deployment where Gateway is created in ArgoCD application.

[arkodg]

Makes sense, similar to #1706

• we'll need to add something similar where the Deployment, Service, ConfigMap gets linked to the Gateway, or the GatewayClass in case MergeGateways is enabled

[cnvergence]

+1

[arkodg]

rethinking, this work may be a little bit more involved, we lose exact info of the Kind and Namespace & Name when converting from gateway-api to IR, so this will cost some extra memory

gateway/internal/ir/infra.go

Line 39 in 3d51933

type ProxyInfra struct {

[zirain]

same to service? and what about mergedGateway?

[cnvergence]

merged gateways should ref the GatewayClass

[arkodg]

not the prettiest and slightly fragile, but the easiest solution is to update the ownerReference based on the owning labels created

gateway/internal/gatewayapi/helpers.go

Line 230 in 8a01dd6

func GatewayOwnerLabels(namespace, name string) map[string]string {

[arkodg]

this cannot be implemented with the default deployment configuration because ownerReferences dont have cross namespace support, the Gateway exists in a user namespace and the generated resources are deployed in the envoy-gateway-system by default

[arkodg]

this can only work for the mergeGateways case where the owner is a cluster scoped resource like GatewayClass

[sadovnikov]

not the prettiest and slightly fragile, but the easiest solution is to update the ownerReference based on the owning labels created

@arkodg, I tried adding the metadata.ownerReferences manually. Argo CD picks up and shows the Deployment and the Service. However, the labels are not enough because uid of the owner is a required attribute

A copy of your changes has been stored to "/tmp/kubectl-edit-559773258.yaml"
error: map: map[apiVersion:gateway.networking.k8s.io/v1 blockOwnerDeletion:false kind:Gateway name:default] does not contain declared merge key: uid