"Warning: Input.getDOMNode(...) is deprecated. Please use ReactDOM.findDOMNode(instance) instead."

[craigdallimore]

It looks like like this polyfill is using a deprecated method ".getDOMNode()" here. This produces a deprecation warning in the console when used with [email protected].

Looks like all it needs is the presence of react-dom and

this.setSelectionIfNeeded(ReactDOM.findDOMNode(this));

Happy to help out if you'd like a PR.

[quantizor]

@craigdallimore Hey, yup we are not updated for 0.14 as of yet. PRs welcome. Note that the final code needs to be backward compatible with <0.13

[craigdallimore]

Note that the final code needs to be backward compatible with <0.13

Hello @yaycmyk!

I'm not quite sure that there is a good way to satisfy both sides of the breaking change - 0.13 uses this.getDOMNode() and 0.14 prefers ReactDOM.findDOMNode(this).

I believe the point of the warning is to push us to change how we access nodes, as this.getDOMNode is probably not going to work in 0.15.

Is it not acceptable to have a new release that expects ^[email protected] and let [email protected] users stay on [email protected]?

[quantizor]

I'm planning on a rewrite for 2.0.0 that will utilize 0.14

On Nov 26, 2015, at 10:49 AM, Craig Dallimore [email protected] wrote:

Note that the final code needs to be backward compatible with <0.13

Hello @yaycmyk!

I'm not quite sure that there is a good way to satisfy both sides of the breaking change - 0.13 uses this.getDOMNode() and 0.14 prefers ReactDOM.findDOMNode(this).

I believe the point of the warning is to push us to change how we access nodes, as this.getDOMNode is probably not going to work in 0.15.

Is it not acceptable to have a new release that expects ^[email protected] and let [email protected] users stay on [email protected]?

—
Reply to this email directly or view it on GitHub.