Skip to content

Commit

Permalink
Merge pull request #430 from ef4/typo
Browse files Browse the repository at this point in the history
fix potential spelling mistake
  • Loading branch information
ef4 authored Aug 10, 2021
2 parents c620a67 + ed179b9 commit 684d97a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/upgrade-guide-2.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
- apps must add webpack to their own dependencies (`yarn add --dev webpack@5` or `npm install --save-dev webpack@5`)
- apps that were adding css handling (like `css-loader`, `style-loader`, and `MiniCSSExtraPlugin`) to the webpack config must remove those, because they're now included by default for compatibility with the embroider v2 package spec.
- apps should confirm that their deployment strategy includes all files produced under `dist` (not just the traditional expected ones like `dist/assets/your-app.js` and `dist/assets/vendor.js`)
- apps that use `fingerprint.preprend` to move their assets to a different origin will also need to set `autoImport.publicAssetURL`. See example below.
- apps that use `fingerprint.prepend` to move their assets to a different origin will also need to set `autoImport.publicAssetURL`. See example below.
- addons that upgrade to ember-auto-import >= 2 will only work in apps that have ember-auto-import >= 2, so they should do their own semver major releases when they upgrade
- our `alias` option has changed slightly to align better with how it works in webpack
- we dropped support for node < 12 and ember-source < 3.4 and ember-cli < 3.4.
Expand Down

0 comments on commit 684d97a

Please sign in to comment.