Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLEASE keep the repo tag be semver2 compliant #3837

Closed
liesauer opened this issue Nov 12, 2019 · 5 comments
Closed

PLEASE keep the repo tag be semver2 compliant #3837

liesauer opened this issue Nov 12, 2019 · 5 comments
Assignees

Comments

@liesauer
Copy link

since runtime versioning is semver2 compatible, u should keep this repo be semver2 compatible all the time too. but what u guys are doing???
image

@dagood
Copy link
Member

dagood commented Nov 12, 2019

Thanks for pointing it out, this is strange. @Anipik, I see you pushed the tag, why is a pseudo-semver-v1 version used for the preview3 tag?

(It's not a conventional semver v1 tag either, because 2 would be 02.)

@Anipik
Copy link
Contributor

Anipik commented Nov 12, 2019

I used pseudo-semver-v1 for preview3 because we have been using this convention all along(except for preview2). i can change it for preview3 if we want to use semver2 convention going forward

@dagood
Copy link
Member

dagood commented Nov 12, 2019

Looks like @leecow pushed the p1 tag, @vivmishra pushed the p2 one. Just not coordinated, then, I guess! IMO it should match the product's version, which would be v3.1.0-preview3.19553.2 in this case.

@Anipik
Copy link
Contributor

Anipik commented Nov 12, 2019

i will change it to that in the morning

@dagood
Copy link
Member

dagood commented Nov 12, 2019

Thanks!

image

@msftgits msftgits transferred this issue from dotnet/core-setup Jan 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants