Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide error recap/summary at the end of a large build in tl #10681

Closed
rainersigwald opened this issue Sep 20, 2024 · 2 comments · Fixed by #11105
Closed

Provide error recap/summary at the end of a large build in tl #10681

rainersigwald opened this issue Sep 20, 2024 · 2 comments · Fixed by #11105
Assignees
@MichalPavlik
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Feature Request needs-design Requires discussion with the dev team before attempting a fix. Priority:1 Work that is critical for the release, but we could probably ship without triaged

Comments

@rainersigwald
Copy link
Member

In a very large build, errors may have scrolled well offscreen before the end of the build, leaving a terminal window with a sea of green "project succeeded" messages followed by an unhelpful "build failed with 8 errors".

We decided not to repeat every error because of noise, but we could consider a heuristic based on terminal height that could emit an error recap if errors were emitted but are now offscreen.

(I could swear we had this conversation several times but I can't find a bug tracking it)
@rainersigwald rainersigwald added Feature Request Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. labels Sep 20, 2024
@maridematte maridematte added needs-design Requires discussion with the dev team before attempting a fix. triaged labels Sep 24, 2024
@maridematte
Copy link
Contributor

Team triage: @baronfel what is your opinion on the priority of this issue?

@baronfel
Copy link
Member

It's not technically blocking but it is a major customer dissatisfaction as soon as you have builds with more than...say 10 projects or TFMs being built. We should do it definitely for .NET 10, but ideally earlier - possibly for 9.0.200.

@baronfel baronfel changed the title Provide error recap at the end of a large build in tl Provide error recap/summary at the end of a large build in tl Sep 26, 2024
@maridematte maridematte added the Priority:1 Work that is critical for the release, but we could probably ship without label Nov 6, 2024
@baronfel baronfel mentioned this issue Dec 2, 2024
Closed
@MichalPavlik MichalPavlik self-assigned this Dec 4, 2024
@MichalPavlik MichalPavlik mentioned this issue Dec 6, 2024
Merged
@rainersigwald rainersigwald marked this as a duplicate of #11001 Dec 13, 2024
@rainersigwald rainersigwald mentioned this issue Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichalPavlik MichalPavlik

Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Feature Request needs-design Requires discussion with the dev team before attempting a fix. Priority:1 Work that is critical for the release, but we could probably ship without triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a error/recap summary at the end of the build dotnet/msbuild
4 participants
@baronfel @rainersigwald @maridematte @MichalPavlik