Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Localize MSBuild messages with MSBuildInternalMessage task #10171

Closed
YuliiaKovalova opened this issue May 24, 2024 · 0 comments · Fixed by #10388
Closed

[Feature Request]: Localize MSBuild messages with MSBuildInternalMessage task #10171

YuliiaKovalova opened this issue May 24, 2024 · 0 comments · Fixed by #10388
Assignees
@JaynieBai
Labels
Area: Common Targets Feature Request Good First Issue Self-contained issues good for first-time contributors. needs-investigation Priority:2 Work that is important, but not critical for the release

Comments

@YuliiaKovalova
Copy link
Member

YuliiaKovalova commented May 24, 2024 •
edited
Loading

Summary

The recently added task allows to produce localized messages:
https://github.com/dotnet/msbuild/blob/79dff86b18613cfe3510b719ac28e8a8c3e7f96c/src/Tasks/MSBuildInternalMessage.cs

Please use it instead of targets

msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets

Line 883 in 79dff86

<Warning Condition=" '$(EnableBaseIntermediateOutputPathMismatchWarning)' == 'true' And '$(_InitialBaseIntermediateOutputPath)' != '$(BaseIntermediateOutputPath)' And '$(BaseIntermediateOutputPath)' != '$(MSBuildProjectExtensionsPath)' "

Background and Motivation

MsBuild produces unlocalized messages for some specific validation cases that happen in scope of target.
The example of the task usage: https://github.com/YuliiaKovalova/msbuild/blob/be21253d85f7766356880d376e26aaa69c34c4cd/src/Tasks/Microsoft.Common.CurrentVersion.targets#L862

Proposed Feature

Refactor the existing messages , produced by with hardcoded text.

Alternative Designs

No response
@YuliiaKovalova YuliiaKovalova mentioned this issue May 24, 2024
Merged
@YuliiaKovalova YuliiaKovalova added Priority:2 Work that is important, but not critical for the release Area: Common Targets Good First Issue Self-contained issues good for first-time contributors. labels May 24, 2024
@JaynieBai JaynieBai mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaynieBai JaynieBai

Labels
Area: Common Targets Feature Request Good First Issue Self-contained issues good for first-time contributors. needs-investigation Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Localize the text in the common target JaynieBai/msbuild
3 participants
@JaynieBai @AR-May @YuliiaKovalova