Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Support removing IDENTITY from a column #3993

Closed
MaximBalaganskiy opened this issue Dec 6, 2015 · 5 comments
Closed

Migrations: Support removing IDENTITY from a column #3993

MaximBalaganskiy opened this issue Dec 6, 2015 · 5 comments

Comments

@MaximBalaganskiy
Copy link

When an SQL table is created with Id column it gets IDENTITY by default. Adding a ValueGeneratedNever method call later generates a migration which does not remove this clause.

Example repo. It has two migrations - Initial will generate a table with an Identity column. The second one was supposed to remove that Identity.

@bricelam
Copy link
Contributor

bricelam commented Dec 9, 2015

Notes for triage: If I remember right, we're mimicking EF6 behavior because removing IDENTITY requires a rebuild.

@divega
Copy link
Contributor

divega commented Dec 9, 2015

BTW, we said in the past that we wanted to give the user some kind of warning rather than silently ignoring changes that would cause table rebuilds.

@rowanmiller rowanmiller changed the title Migration does not remove IDENTITY from a column Migrations: Support removing IDENTITY from a column Dec 15, 2015
@rowanmiller rowanmiller added this to the Backlog milestone Dec 15, 2015
@rowanmiller
Copy link
Contributor

Dependent upon #329

@divega
Copy link
Contributor

divega commented Apr 1, 2016

This seems to be a dupe since we have decided to warn for RTM (tracked in #4783) and we need table rebuilds to work for any further improvement (tracked in #329).

cc @rowanmiller

@bricelam
Copy link
Contributor

bricelam commented Oct 6, 2016

Closing as a dupe of #5345. We throw now.

@bricelam bricelam closed this as completed Oct 6, 2016
@bricelam bricelam removed this from the Backlog milestone Oct 6, 2016
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants