Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf regression in EF #16405

Closed
mkArtakMSFT opened this issue Jul 2, 2019 · 6 comments
Closed

Perf regression in EF #16405

mkArtakMSFT opened this issue Jul 2, 2019 · 6 comments

Comments

@mkArtakMSFT
Copy link
Member

It seems a change went in today and regressed the Single Query performance for all the EF-involved scenarios:
image

@ajcvickers
Copy link
Contributor

@roji Please add this to your existing perf work this week.

@DamianEdwards
Copy link
Member

Note that not all of those scenarios are EF, some use raw ADO.NET, and others use Dapper. So whatever's caused this is affecting all variants, not just EF.

@smitpatel
Copy link
Contributor

Where is the source code for those tests?

@DamianEdwards
Copy link
Member

https://github.com/aspnet/Benchmarks/tree/master/src/Benchmarks

@roji
Copy link
Member

roji commented Jul 3, 2019

The regression seems to have disappeared:

image

It's pretty weird: the drop only shows on Linux+Physical, the others are pretty flat. It's also odd for only SingleQuery to regress, across raw/dapper/EF, but no other DB benchmarks to show anything.

I'd put my money on some unrelated environmental thing (some process inadvertently running at the same time as the benchmark?), but let's follow closely.

Closing for now unless anyone has any objections.

@roji roji closed this as completed Jul 3, 2019
@roji
Copy link
Member

roji commented Jul 3, 2019

One more important note (@smitpatel and others): the TechEmpower tests are pinned to preview5 of EF Core, since we're running with Npgsql which does not constantly follow master branch - so nothing we currently do in EF Core would actually show up here. We do have the newish EF Core microbenchmarks tab in PowerBI which does follow continuous EF Core perf.

I typically sync up Npgsql every preview release, but didn't do it for preview6 (plan to do so for preview7 as soon as that's released).

@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants