Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing UseRowNumberForPaging #13959

Closed
ajcvickers opened this issue Nov 14, 2018 · 23 comments
Closed

Consider removing UseRowNumberForPaging #13959

ajcvickers opened this issue Nov 14, 2018 · 23 comments
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.

Comments

@ajcvickers
Copy link
Contributor

ajcvickers commented Nov 14, 2018

Because it is generally only needed in SQL Server 2008, which is out of support.

If you're reading this and you use UseRowNumberForPaging, then please comment on this issue and let us know why you are using it.

@ghost
Copy link

ghost commented Nov 15, 2018

Because we payed for the standard version of SQL Server 2008. It works perfectly for us. Why to buy a new version? Does Microsoft make a free update from 2008 to 2012?

@felipepessoto
Copy link
Contributor

@ajcvickers, I still see some customers using it. The extended support ends in 2019.

I had to use the rownumber flag recently.

@duoanfen
Copy link

duoanfen commented Nov 15, 2018

because we only buy 2008 licence on production environment which many project is already runing on it and working without problem, if we change to 2012 only for this problem, we must buy a new licence for 2012 and only for this netcore project. so i think it is not a good plan

@duoanfen
Copy link

duoanfen commented Nov 15, 2018

I find a way to solve this error temporary, use a lock on ToList() function, with this lock it run ok, but if we do like this it can not handle many request in the same time, so it is only a temporary solution to this problem.
code is:

                List<TMenu> rs = null;
                lock (StaticLock.MenuListLock)
                {
                    rs = query.ToList();
                }

@ghost
Copy link

ghost commented Nov 15, 2018

Yeah, to replace a working database server is not as easy as to replace a web browser with a newer one. Even after a long time it can work inside a virtual machine with an older OS. I can not count how many SQL Servers 2008 are now used, but i think it is a very substantial number. People don't like to throw away money on what they don't need.

@lxs3626
Copy link

lxs3626 commented Nov 15, 2018

Big steps, easy to pull eggs.

@duoanfen
Copy link

哈哈哈 楼上的笑死我了,翻译过来就是:步子大了容易扯着淡

@ajcvickers
Copy link
Contributor Author

Thanks for the feedback all.

@ajcvickers
Copy link
Contributor Author

Based on feedback, we're not planning to remove this functionality in the 3.0 release.

@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Nov 16, 2018
@prochnowc
Copy link

Same here. SQL Server 2008 is still in use for some databases in the company. Thanks for not removing it in 3.0. In our apps we implemented probing the SQL server version on startup and set the flag accordingly.

@xrkolovos
Copy link

Same here. Our clients still has SQL server 2008. This would force us to go back to ef6

@xrkolovos
Copy link

If you plan to remove it, please provide a way for us to add it in our code.

@ErikEJ
Copy link
Contributor

ErikEJ commented Nov 18, 2018

Move it to a seperate NuGet package? (To see actual usage and to isolate) ?

@duoanfen
Copy link

duoanfen commented Jan 21, 2019

We already change SQL Servcer to Mysql for DB service, Because our company leader do not agree to pay for money to update to sqlserver 2012, Change to Mysql that we can deploy .netcore project all on Ubuntu or CentOS. So I think I will never experience this problem in the future, Thanks.
From Zhongguancun Beijing China

@ghost
Copy link

ghost commented Jan 21, 2019

We already change SQL Servcer to Mysql for DB service, Because our company leader do not agree to pay for money to update to sqlserver 2012, Change to Mysql that we can deploy .netcore project all on Ubuntu or CentOS. So I think I will never experience this problem in the future, Thanks.
From Zhongguancun Beijing China

Congratulation. They fixed it in netcore 2.2. We gave it a thought too. But SQL Server has better backup and restore, we have a lot of reports in Reporting Services, and we also use SQL Server Service Broker. Moving it to a new database server looks very tedious.

@VarunAkula
Copy link

VarunAkula commented Nov 15, 2019

To make the $skip query option of OData to work fine with Microsoft SQL Server 2008 R2, we are using UseRowNumberForPaging.

We have a plan to upgrade Microsoft SQL Server to 2012 or 2014 shortly. Could someone confirm that there won't be an issue if we remove the usage of UseRowNumberForPaging? @ajcvickers

@xrkolovos
Copy link

Please provide a way for us to add it in our code, we don't want to stuck in .net core 2.2

@h0730303779
Copy link

h0730303779 commented Dec 17, 2019

UseRowNumberForPaging efcore 3.1 不能用了吗 震惊 蛋疼

Row-number paging is no longer supported. See https://aka.ms/AA6h122 for more information.
!!!
Please support because our customer database is 2008

@duoanfen
Copy link

@h0730303779 我们之前用的是netcore2.1,那个时候不能用,现在3版本升级3.0+了具体能不能用不知道啊,我们没升级,改用mysql了

@h0730303779
Copy link

@h0730303779 我们之前用的是netcore2.1,那个时候不能用,现在3版本升级3.0+了具体能不能用不知道啊,我们没升级,改用mysql了

不能我也切 mysql了 看见 隔壁issues 有个大佬要自己重写查询. 支持RowNumber分页 等待吧

@multinerd
Copy link

UseRowNumberForPaging efcore 3.1 不能用了吗 震惊 蛋疼

Row-number paging is no longer supported. See https://ak.ms/AA6h122 for more information.
!!!
Please support because our customer database is 2008

Another Microsoft url 404's...

@mentianyi
Copy link

EF 3 Break change

@dlmotter
Copy link

dlmotter commented Aug 3, 2020

We need UseRowNumberForPaging because Azure Synapse Analytics Server (Azure Data Warehouse) doesn't support OFFSET either. In order to use EF Core 3.1 with ASAS you have to to weird stuff to skip records in memory, especially if you're using OData.

@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.
Projects
None yet
Development

No branches or pull requests