From 232c47eebc201b9a2cda8fbea4427e130339680e Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 13 Sep 2024 08:28:14 -0700 Subject: [PATCH] [release/9.0] [Identity][Templates] Ensure placeholders don't overlap with text (#57789) Backport of #57783 to release/9.0 /cc @javiercn # [Identity][Templates] Ensure placeholders don't overlap with text Placeholder text on input textboxes overlaps with the label texts. ## Description * As part of an accessibility fix, we started displaying placeholders on input elements. * In some circumstances, these placeholders overlap with the labels on the input text boxes, making it problematic to read them. * The fix addresses this by reducing the size of the placeholders and making inputs bigger to avoid any overlap. Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/3081 ## Customer Impact When the window size is small enough, customers could see overlapped text that's hard to read and is sometimes even impossible. ## Regression? - [X] Yes - [ ] No 8.0 since we introduced this behavior on 9.0 as part of accessibility fixes. ## Risk - [ ] High - [ ] Medium - [x] Low The attached videos serve as validation of the fix, in addition to that, the UI is completely customizable by customers. ## Verification - [X] Manual (required) - [ ] Automated **Old behavior** ![image](https://github.com/user-attachments/assets/ae72b769-7215-4b0a-954b-a59fb84fbb7d) ![image](https://github.com/user-attachments/assets/f9e32542-7aa7-47ba-876e-567435ef4bdc) **New behavior** https://github.com/user-attachments/assets/6eae3396-9794-402d-af65-e0bc89257a44 https://github.com/user-attachments/assets/0343b4fc-5f55-4e46-a276-67c4c97645e2 ## Packaging changes reviewed? - [ ] Yes - [ ] No - [X] N/A ---- ## When servicing release/2.1 - [ ] Make necessary changes in eng/PatchConfig.props --- .../UI/src/Areas/Identity/Pages/V5/Account/Login.cshtml | 4 ++-- .../Pages/V5/Account/Manage/ChangePassword.cshtml | 8 ++++---- .../Areas/Identity/Pages/V5/Account/Manage/Email.cshtml | 8 ++++---- .../Pages/V5/Account/Manage/EnableAuthenticator.cshtml | 2 +- .../Areas/Identity/Pages/V5/Account/Manage/Index.cshtml | 4 ++-- .../Identity/Pages/V5/Account/Manage/SetPassword.cshtml | 6 +++--- .../Areas/Identity/Pages/V5/Account/Manage/_Layout.cshtml | 4 ++-- .../src/Areas/Identity/Pages/V5/Account/Register.cshtml | 4 ++-- .../BlazorWeb-CSharp/Components/Account/Pages/Login.razor | 4 ++-- .../Components/Account/Pages/Manage/ChangePassword.razor | 8 ++++---- .../Components/Account/Pages/Manage/Email.razor | 8 ++++---- .../Account/Pages/Manage/EnableAuthenticator.razor | 4 ++-- .../Components/Account/Pages/Manage/Index.razor | 6 +++--- .../Components/Account/Pages/Manage/SetPassword.razor | 6 +++--- .../Components/Account/Pages/Register.razor | 4 ++-- .../Components/Account/Shared/ManageLayout.razor | 4 ++-- 16 files changed, 42 insertions(+), 42 deletions(-) diff --git a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Login.cshtml b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Login.cshtml index 6354164a81ace..a5179d31900b9 100644 --- a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Login.cshtml +++ b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Login.cshtml @@ -7,7 +7,7 @@

@ViewData["Title"]

-
+

Use a local account to log in.

@@ -46,7 +46,7 @@
-
+

Use another service to log in.


diff --git a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/ChangePassword.cshtml b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/ChangePassword.cshtml index 073603a30c572..a42b9a787ba07 100644 --- a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/ChangePassword.cshtml +++ b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/ChangePassword.cshtml @@ -8,21 +8,21 @@

@ViewData["Title"]

-
+
- +
- +
- +
diff --git a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/Email.cshtml b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/Email.cshtml index f3278e9ef56cd..cfd9c8697ed98 100644 --- a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/Email.cshtml +++ b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/Email.cshtml @@ -8,13 +8,13 @@

@ViewData["Title"]

-
+
@if (Model.IsEmailConfirmed) {
- +
@@ -24,13 +24,13 @@ else {
- +
}
- +
diff --git a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/EnableAuthenticator.cshtml b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/EnableAuthenticator.cshtml index fefa57f2b7eec..8bda5916fc69f 100644 --- a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/EnableAuthenticator.cshtml +++ b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/EnableAuthenticator.cshtml @@ -32,7 +32,7 @@ with a unique code. Enter the code in the confirmation box below.

-
+
diff --git a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/Index.cshtml b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/Index.cshtml index 94b669d625f88..3c37fd4351f9e 100644 --- a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/Index.cshtml +++ b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/Index.cshtml @@ -12,11 +12,11 @@
- +
- +
diff --git a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/SetPassword.cshtml b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/SetPassword.cshtml index a4ba058be4c44..9f57681308f7d 100644 --- a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/SetPassword.cshtml +++ b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/SetPassword.cshtml @@ -12,16 +12,16 @@ account so you can log in without an external login.

-
+
- +
- +
diff --git a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/_Layout.cshtml b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/_Layout.cshtml index f2c6257991e3e..f25654451641d 100644 --- a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/_Layout.cshtml +++ b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Manage/_Layout.cshtml @@ -15,10 +15,10 @@

Change your account settings


-
+
-
+
@RenderBody()
diff --git a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Register.cshtml b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Register.cshtml index 6fbfc8fa4a4a8..dc9a807d1f794 100644 --- a/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Register.cshtml +++ b/src/Identity/UI/src/Areas/Identity/Pages/V5/Account/Register.cshtml @@ -7,7 +7,7 @@

@ViewData["Title"]

-
+

Create a new account.


@@ -30,7 +30,7 @@
-
+

Use another service to register.


diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Login.razor b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Login.razor index 606f47019c277..292750b79a4c5 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Login.razor +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Login.razor @@ -14,7 +14,7 @@

Log in

-
+
@@ -55,7 +55,7 @@
-
+

Use another service to log in.


diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/ChangePassword.razor b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/ChangePassword.razor index c9ed0a7894f91..dc21755a47b0e 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/ChangePassword.razor +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/ChangePassword.razor @@ -15,22 +15,22 @@

Change password

-
+
- +
- +
- +
diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/Email.razor b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/Email.razor index d57665c1b206e..c8b1518061aef 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/Email.razor +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/Email.razor @@ -18,7 +18,7 @@
-
+
@@ -28,7 +28,7 @@ @if (isEmailConfirmed) {
- +
@@ -38,13 +38,13 @@ else {
- +
}
- +
diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/EnableAuthenticator.razor b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/EnableAuthenticator.razor index 4b8133f87d2df..1872e9e6c83b1 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/EnableAuthenticator.razor +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/EnableAuthenticator.razor @@ -48,11 +48,11 @@ else with a unique code. Enter the code in the confirmation box below.

-
+
- +
diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/Index.razor b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/Index.razor index 8eb27d69bcbdb..bff831a1d852e 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/Index.razor +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/Index.razor @@ -15,16 +15,16 @@
-
+
- +
- +
diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/SetPassword.razor b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/SetPassword.razor index 9bef817bd4344..79eabe780fff2 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/SetPassword.razor +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/SetPassword.razor @@ -18,17 +18,17 @@ account so you can log in without an external login.

-
+
- +
- +
diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Register.razor b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Register.razor index cc0d6fc2ed8eb..6da721d050f26 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Register.razor +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Register.razor @@ -20,7 +20,7 @@

Register

-
+
@@ -45,7 +45,7 @@
-
+

Use another service to register.


diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Shared/ManageLayout.razor b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Shared/ManageLayout.razor index cc4f4c0e7c10a..248a2ed161a1f 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Shared/ManageLayout.razor +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Shared/ManageLayout.razor @@ -11,10 +11,10 @@

Change your account settings


-
+
-
+
@Body