Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot see relay lists created from certain other clients (Damus does not recognize relay list kind 10002) #2120

Open
alltheseas opened this issue Apr 4, 2024 · 11 comments
Assignees
Labels
enhancement Improvement interop interoperability and compatibility with other nostr apps kind-3 kind-10002 NIP nip-65 relay unexpected
Milestone

Comments

@alltheseas
Copy link
Collaborator

What happens
I cannot see relay lists from keys created on Coracle on user's profile.

What I expect to happen
I expect to see relay lists from keys created on other clients, like Coracle, on user's profile.

Link to noteID, npub
Provide link to relevant noteID, npub etc.

Screenshots/video recording
If applicable, add screenshots to help explain your problem.

** Versions **
Damus version: 1.7.2 (1)

Steps To Reproduce
Steps to reproduce the behavior:

  1. Open Damus
  2. Go to npub1jmqznxuxxxrnaj3m7esjrwauxmvg742ltj0gsgumlmtxukzq99yqfrl6g5
  3. Check for relay list
  4. Open Iris.to
  5. Go to npub1jmqznxuxxxrnaj3m7esjrwauxmvg742ltj0gsgumlmtxukzq99yqfrl6g5
  6. Check for relay list (to confirm that relay list exists, and does not display on Damus)

Additional context
It could be that Damus does not support relay list 10002

@alltheseas alltheseas added enhancement Improvement Needs recreation Issues requires concrete steps for recreation unexpected relay labels Apr 4, 2024
@alltheseas
Copy link
Collaborator Author

@alltheseas
Copy link
Collaborator Author

Kind 10002 defined in NIP-65

@alltheseas
Copy link
Collaborator Author

@jb55 advised damus

Generates nip-65 relay lists

note1pdkcufr9ja7dhe5ac6l7luh8fdr5vr8pue5waswkffgwhcxzsvxsescdek

@alltheseas
Copy link
Collaborator Author

@jb55 advises

probably time to actually switch to proper relay lists instead of kind3 😅

image

@jb55 jb55 removed the Needs recreation Issues requires concrete steps for recreation label Sep 19, 2024
@alltheseas alltheseas modified the milestones: 1.9backlog, 1Q25 Jan 17, 2025
@alltheseas
Copy link
Collaborator Author

update from kind3

@alltheseas
Copy link
Collaborator Author

@danieldaquino to spike ~1 hour to estimate workload

@danieldaquino
Copy link
Contributor

To make this happen, I am having to study a significant amount about all aspects regarding relays, relay lists, relay pools, etc. throughout the app.

I might have to do significant changes to several related areas of code.

It may be worth for me to take advantage of the time investment in learning all this to address (or at least prepare) for tangential relay-stack improvements such as:

In other words, it might be efficient to bundle up this change with related improvements since I am significantly studying and refactor a lot of relay-related stuff. It's a similar strategy that I employed in #2458

I am open to suggestions as to what related improvements may be worth considering when bundling this.

@danieldaquino
Copy link
Contributor

Migrated most of the codebase to the new model, except for HomeModel. HomeModel is more complicated, still a work in progress.

@danieldaquino
Copy link
Contributor

@danieldaquino
Copy link
Contributor

Migrated most of the codebase to the new model, except for HomeModel. HomeModel is more complicated, still a work in progress.

Migrated most of that, still a few others left. There is a lot of ground to cover, but it will be worth it.

@danieldaquino
Copy link
Contributor

I created a draft PR: #2911, which is very large and risky, but brings us much much closer to implementing the local relay model and solving many of its associated issues.

I believe we might need to change plans for this ticket. This is very difficult to implement properly under the current app architecture without significant refactoring.

Thus, I believe it might be worthwhile implementing this alongside the local relay model project (since it requires a big refactor anyways). We can start out as an experimental branch with several untested changes and keep fixing bugs until it is as stable as master, and then merge everything?

CC @jb55 @alltheseas

Note: I also experimented with merging this work with the new NostrDB branch (#2912), but have not implemented the local relay model there. It should not be too far to a local relay model prototype, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement interop interoperability and compatibility with other nostr apps kind-3 kind-10002 NIP nip-65 relay unexpected
Projects
Status: In Progress
Development

No branches or pull requests

3 participants