Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize cashu redeem code #1788

Closed
Tracked by #2228
alltheseas opened this issue Dec 2, 2023 · 10 comments
Closed
Tracked by #2228

Recognize cashu redeem code #1788

alltheseas opened this issue Dec 2, 2023 · 10 comments
Labels

Comments

@alltheseas
Copy link
Collaborator

alltheseas commented Dec 2, 2023

what happens
Very long cashu gibberish string is displayed

what could happen
Damus recognizes cashu redeem string, shows
-the amount
-a "redeem" button,
-copy string button

suggested initial approach

  1. Cashu: prefixed link are detected
  2. an invoice-like "redeem" button appears instead of gibberish characters
  3. if tap on redeem, cashu: opens default cashu wallet
  4. there is a copy string button adjacent to redeem
  5. list amount (sats)

https://damus.io/note17ek90arl9y6vmut6t48d7kfgp9rfdx0c0x9wflyq6v4shvg46ddsh0gud2

image

@KKA11010
Copy link

KKA11010 commented Dec 3, 2023

Also a "open in wallet" button. It provides the best possible UX.

Mobile cashu wallets support deep links "cashu:token" or cashu://token"

They claim the token and lets you spend it again without melting to your LN wallet.

@alltheseas
Copy link
Collaborator Author

Also a "open in wallet" button. It provides the best possible UX.

Mobile cashu wallets support deep links "cashu:token" or cashu://token"

They claim the token and lets you spend it again without melting to your LN wallet.

If there were a redeem button, is there any other place it would take you other than a wallet with the cashu: prefix?

@KKA11010
Copy link

KKA11010 commented Dec 3, 2023

Also a "open in wallet" button. It provides the best possible UX.

Mobile cashu wallets support deep links "cashu:token" or cashu://token"

They claim the token and lets you spend it again without melting to your LN wallet.

If there were a redeem button, is there any other place it would take you other than a wallet with the cashu: prefix?

Not sure if other apps support the cashu: prefix. (Apps have to specify the prefix they support f.e lightning: for LN wallets) Currently it is a native Ecash wallet thing.

@KKA11010
Copy link

KKA11010 commented Dec 3, 2023

Some thoughts on how the user can interact with an inline Ecash

  1. Redeem via Lightning within the Nostr client.
  2. Redeem into Ecash wallet (best UX imo and most private).
  3. Display QR to redeem by scanning with an Ecash wallet
  4. Copy the string into clipboard

@alltheseas
Copy link
Collaborator Author

@alltheseas
Copy link
Collaborator Author

I think decrypt with nsec key and copy to cashu wallet. @dr. calle 👁️⚡👁️ posted NUT-11 https://github.com/cashubtc/nuts/blob/main/11.md which makes most sense for Nostr usage.

https://github.com/cashubtc/nuts/blob/main/11.md

@alltheseas
Copy link
Collaborator Author

@alltheseas
Copy link
Collaborator Author

@KKA11010 in the cashu link is there a source/server/mint name that can be displayed? Is it desirable to display this?

@KKA11010
Copy link

KKA11010 commented Dec 4, 2023

@KKA11010 in the cashu link is there a source/server/mint name that can be displayed? Is it desirable to display this?

Yes the mint URL is encoded in the token. The wallet shows it once you redeem it. I would say no need to display it in Nostr clients.

@alltheseas
Copy link
Collaborator Author

@ericholguin 👀 👀

@alltheseas alltheseas added the nuts label Dec 4, 2023
@alltheseas alltheseas mentioned this issue May 7, 2024
15 tasks
@jb55 jb55 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants