Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mill Spotless Plugin (500USD Bounty) #3888

Open
lihaoyi opened this issue Nov 2, 2024 · 2 comments · May be fixed by #4464
Open

Add Mill Spotless Plugin (500USD Bounty) #3888

lihaoyi opened this issue Nov 2, 2024 · 2 comments · May be fixed by #4464
Labels

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Nov 2, 2024


From the maintainer Li Haoyi: I'm putting a 500USD bounty on this issue, payable by bank transfer on a merged PR implementing this.


Spotless is used by many of our third-party example builds: Gatling, Mockito, and now Arrow-Kt. We should have official support in Mill for a SpotlessModule to allow usage of Spotless in JavaModule, ScalaModule, and KotlinModule

Should be similar in style of PalantirFormatModule, ScalafmtModule, ErrorProneModule, etc.

@ayewo
Copy link
Contributor

ayewo commented Jan 28, 2025

Hey @lihaoyi

I've actually been working on this task for a bit and I've been able to get most of it working locally.

It's clear the effort is much more than the examples PalantirFormatModule, ScalafmtModule, ErrorProneModule you want it to be styled after. Good thing is that you acknowledged as much in this thread.

For instance, the code inside the main spotless.jar does not expose a main class that can be invoked from a separate sub-process. They expect anyone trying to integrate it with a new build tool to create all that plumbing, by looking at how it was done for maven or gradle.

This meant that I first had to build such a main class as a standalone Java project so I could create a spotless based Java formatter. The same approach is used for Scala and Kotlin, which are also in scope of this ticket.

So I'm wondering if you are open to upping the bounty amount?

@ayewo ayewo linked a pull request Feb 3, 2025 that will close this issue
@ayewo
Copy link
Contributor

ayewo commented Feb 4, 2025

@lihaoyi looks like you missed this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants