RuntimeException using recycled bitmap after os memory trim (0.13.0)

[19craig]

Describe the bug
Reported from production app:
Fatal Exception: java.lang.RuntimeException
Canvas: trying to use a recycled bitmap android.graphics.Bitmap@d0434cd
coil.drawable.CrossfadeDrawable.draw
The app reported 5 memory trim events immediately before the crash

Expected behavior
Ideally, reload whatever is necessary to draw the image. At least return an error and don't crash.

To Reproduce
I have not been able to reproduce in development.

Stack Trace
android.graphics.BaseCanvas.throwIfCannotDraw (BaseCanvas.java:66)
android.graphics.RecordingCanvas.throwIfCannotDraw (RecordingCanvas.java:277)
android.graphics.BaseRecordingCanvas.drawBitmap (BaseRecordingCanvas.java:88)
android.graphics.drawable.BitmapDrawable.draw (BitmapDrawable.java:548)
coil.drawable.CrossfadeDrawable.draw (CrossfadeDrawable.java:69)
coil.drawable.CrossfadeDrawable.draw (CrossfadeDrawable.java:83)
android.widget.ImageView.onDraw (ImageView.java:1434)
android.view.View.draw (View.java:21561)
android.view.View.updateDisplayListIfDirty (View.java:20404)
android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4432)
android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4405)
android.view.View.updateDisplayListIfDirty (View.java:20355)
android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4432)
android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4405)
android.view.View.updateDisplayListIfDirty (View.java:20355)
android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4432)
android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4405)
android.view.View.updateDisplayListIfDirty (View.java:20355)
android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4432)
android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4405)
android.view.View.updateDisplayListIfDirty (View.java:20355)
android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4432)
android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4405)
android.view.View.updateDisplayListIfDirty (View.java:20355)
android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4432)
android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4405)
android.view.View.updateDisplayListIfDirty (View.java:20355)
android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4432)
android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4405)
android.view.View.updateDisplayListIfDirty (View.java:20355)
android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4432)
android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4405)
android.view.View.updateDisplayListIfDirty (View.java:20355)
android.view.ViewGroup.recreateChildDisplayList (ViewGroup.java:4432)
android.view.ViewGroup.dispatchGetDisplayList (ViewGroup.java:4405)
android.view.View.updateDisplayListIfDirty (View.java:20355)
android.view.ThreadedRenderer.updateViewTreeDisplayList (ThreadedRenderer.java:575)
android.view.ThreadedRenderer.updateRootDisplayList (ThreadedRenderer.java:581)
android.view.ThreadedRenderer.draw (ThreadedRenderer.java:654)
android.view.ViewRootImpl.draw (ViewRootImpl.java:3755)
android.view.ViewRootImpl.performDraw (ViewRootImpl.java:3559)
android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:2879)
android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:1792)
android.view.ViewRootImpl$TraversalRunnable.run (ViewRootImpl.java:7868)
android.view.Choreographer$CallbackRecord.run (Choreographer.java:967)
android.view.Choreographer.doCallbacks (Choreographer.java:791)
android.view.Choreographer.doFrame (Choreographer.java:726)
android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:952)
android.os.Handler.handleCallback (Handler.java:883)
android.os.Handler.dispatchMessage (Handler.java:100)
android.os.Looper.loop (Looper.java:214)
android.app.ActivityThread.main (ActivityThread.java:7386)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:499)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:980)

Version
Coil 0.13.0
Crash occurred on HMD Global, Android v10

[colinrtwhite]

Hmm I'm not able to reproduce this as well, however a few other instances of this have been reported on Coil's issue tracker. I'm going to leave this issue open as a central location if other people are able to reproduce.

Setting ImageLoader.bitmapPoolingEnabled(false) when constructing your ImageLoader disables Coil's bitmap reference counting + recycling behaviour which should fix this issue. Bitmap pooling is most effective on API 23 and below and is less effective on API 24 and above.

[colinrtwhite]

Added some more explanation on why this can occur here.

[tprochazka]

So without pooling. Thumbnail is cached in memory in which way? As JPG? So then the only thing that happens without pooling is that image needs to be decoded back to the Bitmap object for displaying? But in-memory cache, has already a small size, so this operation will be very fast anyway, especially on 23+ devices right?

[colinrtwhite]

@tprochazka Bitmaps are always stored in memory as their raw, uncompressed format. JPG/PNG/BMP are all compressed formats that only make a difference before the bitmap is decoded. Bitmap pooling only allows Coil to re-use previously allocated bitmaps to decode new images into them. It's object pooling for bitmaps. With bitmap pooling disabled, the only thing that changes is Coil allocates a new bitmap instead of re-using one that was already allocated for a previous image request.

[colinrtwhite]

Closing this out as bitmap pooling is removed in 2.0.0-rc01 so this error shouldn't occur anymore. Check out here for why bitmap pooling was removed.