Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection doesn't drag vertically when text is too long horizontally #1407

Closed
nooblyf opened this issue Jul 14, 2024 · 2 comments
Closed

Selection doesn't drag vertically when text is too long horizontally #1407

nooblyf opened this issue Jul 14, 2024 · 2 comments

Comments

@nooblyf
Copy link

nooblyf commented Jul 14, 2024

Describe the issue

I've noticed this happening only when the text is both vertically and horizontally scrollable

When i select the text and move the mouse up outside the code block the selection should be dragging the selection up? like it does when i move outside horizontally at 00:18

I don't know if i'm explaining this right, here's a screen recording

screen-rec-cm6-selection-drag.mp4

I've tried this in Safari, Chrome and Firefox

Browser and platform

chrome, macOS

Reproduction link

https://codemirror.net/try/?c=aW1wb3J0IHtNZXJnZVZpZXd9IGZyb20gIkBjb2RlbWlycm9yL21lcmdlIgppbXBvcnQge0VkaXRvclZpZXcsIGJhc2ljU2V0dXB9IGZyb20gImNvZGVtaXJyb3IiCmltcG9ydCB7RWRpdG9yU3RhdGV9IGZyb20gIkBjb2RlbWlycm9yL3N0YXRlIgoKbGV0IGRvY0EgPSBgCiAgICBbCiAgICAgIHsKICAgICJpZCI6IDEsCiAgICAidGl0bGUiOiAiSGlzIG1vdGhlciBoYWQgYWx3YXlzIHRhdWdodCBoaW0iLAogICAgImJvZHkiOiAiSGlzIG1vdGhlciBoYWQgYWx3YXlzIHRhdWdodCBoaW0gbm90IHRvIGV2ZXIgdGhpbmsgb2YgaGltc2VsZiBhcyBiZXR0ZXIgdGhhbiBvdGhlcnMuIEhlJ2QgdHJpZWQgdG8gbGl2ZSBieSB0aGlzIG1vdHRvLiBIZSBuZXZlciBsb29rZWQgZG93biBvbiB0aG9zZSB3aG8gd2VyZSBsZXNzIGZvcnR1bmF0ZSBvciB3aG8gaGFkIGxlc3MgbW9uZXkgdGhhbiBoaW0uIEJ1dCB0aGUgc3R1cGlkaXR5IG9mIHRoZSBncm91cCBvZiBwZW9wbGUgaGUgd2FzIHRhbGtpbmcgdG8gbWFkZSBoaW0gY2hhbmdlIGhpcyBtaW5kLiIsCiAgICAidGFncyI6IFsKICAgICAgImhpc3RvcnkiLAogICAgICAiYW1lcmljYW4iLAogICAgICAiY3JpbWUiCiAgICBdLAogICAgInJlYWN0aW9ucyI6IHsKICAgICAgImxpa2VzIjogMTkyLAogICAgICAiZGlzbGlrZXMiOiAyNQogICAgfSwKICAgICJ2aWV3cyI6IDMwNSwKICAgICJ1c2VySWQiOiAxMjEKICB9LAogIHsKICAgICJpZCI6IDIsCiAgICAidGl0bGUiOiAiSGUgd2FzIGFuIGV4cGVydCBidXQgbm90IGluIGEgZGlzY2lwbGluZSIsCiAgICAiYm9keSI6ICJIZSB3YXMgYW4gZXhwZXJ0IGJ1dCBub3QgaW4gYSBkaXNjaXBsaW5lIHRoYXQgYW55b25lIGNvdWxkIGZ1bGx5IGFwcHJlY2lhdGUuIEhlIGtuZXcgaG93IHRvIGhvbGQgdGhlIGNvbmUganVzdCByaWdodCBzbyB0aGF0IHRoZSBzb2Z0IHNlcnZlciBpY2UtY3JlYW0gZmVsbCBpbnRvIGl0IGF0IHRoZSBwcmVjaXNlIGFuZ2xlIHRvIGZvcm0gYSBwZXJmZWN0IGNvbmUgZWFjaCBhbmQgZXZlcnkgdGltZS4gSXQgaGFkIHRha2VuIHllYXJzIHRvIHBlcmZlY3QgYW5kIGhlIGNvdWxkIG5vdyBkbyBpdCB3aXRob3V0IGV2ZW4gcHV0dGluZyBhbnkgdGhvdWdodCBiZWhpbmQgaXQuIiwKICAgICJ0YWdzIjogWwogICAgICAiZnJlbmNoIiwKICAgICAgImZpY3Rpb24iLAogICAgICAiZW5nbGlzaCIKICAgIF0sCiAgICAicmVhY3Rpb25zIjogewogICAgICAibGlrZXMiOiA4NTksCiAgICAgICJkaXNsaWtlcyI6IDMyCiAgICB9LAogICAgInZpZXdzIjogNDg4NCwKICAgICJ1c2VySWQiOiA5MQogIH0sCiAgewogICAgImlkIjogMywKICAgICJ0aXRsZSI6ICJEYXZlIHdhdGNoZWQgYXMgdGhlIGZvcmVzdCBidXJuZWQgdXAgb24gdGhlIGhpbGwuIiwKICAgICJib2R5IjogIkRhdmUgd2F0Y2hlZCBhcyB0aGUgZm9yZXN0IGJ1cm5lZCB1cCBvbiB0aGUgaGlsbCwgb25seSBhIGZldyBtaWxlcyBmcm9tIGhlciBob3VzZS4gVGhlIGNhciBoYWQgYmVlbiBoYXN0aWx5IHBhY2tlZCBhbmQgTWFydGEgd2FzIGluc2lkZSB0cnlpbmcgdG8gcm91bmQgdXAgdGhlIGxhc3Qgb2YgdGhlIHBldHMuIERhdmUgd2VudCB0aHJvdWdoIGhpcyBtZW50YWwgbGlzdCBvZiB0aGUgbW9zdCBpbXBvcnRhbnQgcGFwZXJzIGFuZCBkb2N1bWVudHMgdGhhdCB0aGV5IGNvdWxkbid0IGxlYXZlIGJlaGluZC4gSGUgc2NvbGRlZCBoaW1zZWxmIGZvciBub3QgaGF2aW5nIHByZXBhcmVkIHRoZXNlIGJldHRlciBpbiBhZHZhbmNlIGFuZCBob3BlZCB0aGF0IGhlIGhhZCByZW1lbWJlcmVkIGV2ZXJ5dGhpbmcgdGhhdCB3YXMgbmVlZGVkLiBIZSBjb250aW51ZWQgdG8gd2FpdCBmb3IgTWFydGEgdG8gYXBwZWFyIHdpdGggdGhlIHBldHMsIGJ1dCBzaGUgc3RpbGwgd2FzIG5vd2hlcmUgdG8gYmUgc2Vlbi4iLAogICAgInRhZ3MiOiBbCiAgICAgICJtYWdpY2FsIiwKICAgICAgImhpc3RvcnkiLAogICAgICAiZnJlbmNoIgogICAgXSwKICAgICJyZWFjdGlvbnMiOiB7CiAgICAgICJsaWtlcyI6IDE0NDgsCiAgICAgICJkaXNsaWtlcyI6IDM5CiAgICB9LAogICAgInZpZXdzIjogNDE1MiwKICAgICJ1c2VySWQiOiAxNgogIH0sCiAgewogICAgImlkIjogNCwKICAgICJ0aXRsZSI6ICJBbGwgaGUgd2FudGVkIHdhcyBhIGNhbmR5IGJhci4iLAogICAgImJvZHkiOiAiQWxsIGhlIHdhbnRlZCB3YXMgYSBjYW5keSBiYXIuIEl0IGRpZG4ndCBzZWVtIGxpa2UgYSBkaWZmaWN1bHQgcmVxdWVzdCB0byBjb21wcmVoZW5kLCBidXQgdGhlIGNsZXJrIHJlbWFpbmVkIGZyb3plbiBhbmQgZGlkbid0IHNlZW0gdG8gd2FudCB0byBob25vciB0aGUgcmVxdWVzdC4gSXQgbWlnaHQgaGF2ZSBoYWQgc29tZXRoaW5nIHRvIGRvIHdpdGggdGhlIGd1biBwb2ludGVkIGF0IGhpcyBmYWNlLiIsCiAgICAidGFncyI6IFsKICAgICAgIm15c3RlcnkiLAogICAgICAiZW5nbGlzaCIsCiAgICAgICJhbWVyaWNhbiIKICAgIF0sCiAgICAicmVhY3Rpb25zIjogewogICAgICAibGlrZXMiOiAzNTksCiAgICAgICJkaXNsaWtlcyI6IDE4CiAgICB9LAogICAgInZpZXdzIjogNDU0OCwKICAgICJ1c2VySWQiOiA0NwogIH0KICAgIF0KICBgOwoKbGV0IGRvY0IgPSBgCiAgICBbCiAgICAgIHsKICAgICJpZCI6IDcsCiAgICAidGl0bGUiOiAiVGhpcyBpcyBpbXBvcnRhbnQgdG8gcmVtZW1iZXIuIiwKICAgICJib2R5IjogIlRoaXMgaXMgaW1wb3J0YW50IHRvIHJlbWVtYmVyLiBMb3ZlIGlzbid0IGxpa2UgcGllLiBZb3UgZG9uJ3QgbmVlZCB0byBkaXZpZGUgaXQgYW1vbmcgYWxsIHlvdXIgZnJpZW5kcyBhbmQgbG92ZWQgb25lcy4gTm8gbWF0dGVyIGhvdyBtdWNoIGxvdmUgeW91IGdpdmUsIHlvdSBjYW4gYWx3YXlzIGdpdmUgbW9yZS4gSXQgZG9lc24ndCBydW4gb3V0LCBzbyBkb24ndCB0cnkgdG8gaG9sZCBiYWNrIGdpdmluZyBpdCBhcyBpZiBpdCBtYXkgb25lIGRheSBydW4gb3V0LiBHaXZlIGl0IGZyZWVseSBhbmQgYXMgbXVjaCBhcyB5b3Ugd2FudC4iLAogICAgInRhZ3MiOiBbCiAgICAgICJtYWdpY2FsIiwKICAgICAgImNyaW1lIgogICAgXSwKICAgICJyZWFjdGlvbnMiOiB7CiAgICAgICJsaWtlcyI6IDEyNywKICAgICAgImRpc2xpa2VzIjogMjYKICAgIH0sCiAgICAidmlld3MiOiAxNjgsCiAgICAidXNlcklkIjogNzAKICB9LAogIHsKICAgICJpZCI6IDgsCiAgICAidGl0bGUiOiAiT25lIGNhbiBjb29rIG9uIGFuZCB3aXRoIGFuIG9wZW4gZmlyZS4iLAogICAgImJvZHkiOiAiT25lIGNhbiBjb29rIG9uIGFuZCB3aXRoIGFuIG9wZW4gZmlyZS4gVGhlc2UgYXJlIHNvbWUgb2YgdGhlIHdheXMgdG8gY29vayB3aXRoIGZpcmUgb3V0c2lkZS4gQ29va2luZyBtZWF0IHVzaW5nIGEgc3BpdCBpcyBhIGdyZWF0IHdheSB0byBldmVubHkgY29vayBtZWF0LiBJbiBvcmRlciB0byBrZWVwIG1lYXQgZnJvbSBidXJuaW5nLCBpdCdzIGJlc3QgdG8gc2xvd2x5IHJvdGF0ZSBpdC4iLAogICAgInRhZ3MiOiBbCiAgICAgICJhbWVyaWNhbiIsCiAgICAgICJlbmdsaXNoIgogICAgXSwKICAgICJyZWFjdGlvbnMiOiB7CiAgICAgICJsaWtlcyI6IDEyNzEsCiAgICAgICJkaXNsaWtlcyI6IDM2CiAgICB9LAogICAgInZpZXdzIjogMjExNiwKICAgICJ1c2VySWQiOiA2NwogIH0KICAgIF0KICBgOwoKCm5ldyBNZXJnZVZpZXcoewogIGE6IHsKICAgIGRvYzogZG9jQSwKICAgIGV4dGVuc2lvbnM6IFtdCiAgfSwKICBiOiB7CiAgICBkb2M6IGRvY0IsCiAgICBleHRlbnNpb25zOiBbXQogIH0sCiAgcGFyZW50OiBkb2N1bWVudC5ib2R5Cn0pOw==

@marijnh
Copy link
Member

marijnh commented Jul 15, 2024

Thanks for the report. Attached patch should help.

@nooblyf
Copy link
Author

nooblyf commented Jul 15, 2024

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants