-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert project to TypeScript #261
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
I will update on review tomorrow |
@chintan9 Sounds good |
Any updates? |
The PR has already been merged. I'm not sure if @chintan9 wants to make the changes I've mentioned here, but if he does then that's all that needs to be done...I think. @chintan9 You could publish the package as <Plyr source={source as any} /> Maybe the one thing that comes to mind is that import Plyr from '...'
declare module "plyr-react" {
export Plyr
} Then, just change the I'll leave it up to you to decide. |
You can raise PR |
@iwatakeshi Done |
Hi 👋 ,
I was about to create a draft PR but I've noticed you've merged my fork into a new branch. I've created this issue to give you a heads up and also a run down of the changes.
Heads up:
I'm waiting on a new release from
plyr
since I fixed a type issue yesterday. Also, I'm still testing this is in a Next.js project so I'll let you know if everything works on my end.The rundown:
plyr-react
was not Next.js friendly since it imported the css styles within the component and that is no longer supported. Users will need to import the styles manually. Fixes Unable to Import in NextJS -> Bundled CSS #162source
prop fromoptions
prop since originalOptions
type does not includesource
.Thank you.
Update
Plyr
seems to work correctly with the latest version of Next.js.The text was updated successfully, but these errors were encountered: