Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve manual range picking and fix simulation of diagonal peaks in COSY prediction #3308

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Dec 3, 2024

  • fix the simulation of the peaks in the diagonal in COSY predicted spectra.
  • improve auto-processing 2D raw data, apodization
  • improve/fix the multiplicity determination by multiplet-analysis in manual range picking:
    • by phase the selected range data before analyze the multiplet
    • reduce criteria value for the selection of J coupling

@jobo322 jobo322 linked an issue Dec 3, 2024 that may be closed by this pull request
@jobo322
Copy link
Member Author

jobo322 commented Dec 3, 2024

@lpatiny should we allow the prediction of COSY with cross-peaks with a path length of 4 bonds as max value?

@jobo322 jobo322 changed the title 3307 manual range picking returns wrong multiplicity for quadruplet improve manual range picking n fix simulation of diagonal peaks in COSY prediction Dec 3, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2024

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3739ff8
Status: ✅  Deploy successful!
Preview URL: https://2b2db811.nmrium.pages.dev
Branch Preview URL: https://3307-manual-range-picking-re.nmrium.pages.dev

View logs

@lpatiny
Copy link
Member

lpatiny commented Dec 4, 2024

@lpatiny should we allow the prediction of COSY with cross-peaks with a path length of 4 bonds as max value?

No we should not. But we have the couplings coming back from the prediction so we should check from the result if there are some couplings or not. I would put a threshold of 1.5Hz in order to display the cosy coupling or not.

So we should not simply use 2J or 3J anymore but use the result from the prediction.

@jobo322 jobo322 force-pushed the 3307-manual-range-picking-returns-wrong-multiplicity-for-quadruplet branch from 5716ff7 to 0dae656 Compare December 9, 2024 14:07
@jobo322 jobo322 force-pushed the 3307-manual-range-picking-returns-wrong-multiplicity-for-quadruplet branch from 41dca64 to d79712f Compare February 10, 2025 16:47
@jobo322 jobo322 force-pushed the 3307-manual-range-picking-returns-wrong-multiplicity-for-quadruplet branch from d79712f to e5b1bc1 Compare February 17, 2025 15:31
@jobo322 jobo322 force-pushed the 3307-manual-range-picking-returns-wrong-multiplicity-for-quadruplet branch from e5b1bc1 to cb53890 Compare February 17, 2025 15:39
Copy link
Member

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The COSY prediction seems indeed much more accurate.

It can be tested from:
https://3307-manual-range-picking-re.nmrium.pages.dev/#/SamplesDashboard/8kbdgnwtkbi/Prediction

We now have:

image

And before it was wrongly:

image

@lpatiny lpatiny changed the title improve manual range picking n fix simulation of diagonal peaks in COSY prediction feat: improve manual range picking and fix simulation of diagonal peaks in COSY prediction Feb 20, 2025
@lpatiny lpatiny changed the title feat: improve manual range picking and fix simulation of diagonal peaks in COSY prediction improve manual range picking and fix simulation of diagonal peaks in COSY prediction Feb 20, 2025
@lpatiny
Copy link
Member

lpatiny commented Feb 20, 2025

@jobo322 Is this PR related to issues ?

For COSY I agree it works correctly now.
I forgot about improve manual range picking and how to test it.

@hamed-musallam hamed-musallam changed the title improve manual range picking and fix simulation of diagonal peaks in COSY prediction feat: improve manual range picking and fix simulation of diagonal peaks in COSY prediction Feb 20, 2025
@hamed-musallam hamed-musallam merged commit 24dbc50 into main Feb 20, 2025
10 checks passed
@hamed-musallam hamed-musallam deleted the 3307-manual-range-picking-returns-wrong-multiplicity-for-quadruplet branch February 20, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual range picking returns wrong multiplicity for quadruplet
3 participants