-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve manual range picking and fix simulation of diagonal peaks in COSY prediction #3308
feat: improve manual range picking and fix simulation of diagonal peaks in COSY prediction #3308
Conversation
jobo322
commented
Dec 3, 2024
•
edited
Loading
edited
- fix the simulation of the peaks in the diagonal in COSY predicted spectra.
- improve auto-processing 2D raw data, apodization
- improve/fix the multiplicity determination by multiplet-analysis in manual range picking:
-
- by phase the selected range data before analyze the multiplet
-
- reduce criteria value for the selection of J coupling
@lpatiny should we allow the prediction of COSY with cross-peaks with a path length of 4 bonds as max value? |
Deploying nmrium with
|
Latest commit: |
3739ff8
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2b2db811.nmrium.pages.dev |
Branch Preview URL: | https://3307-manual-range-picking-re.nmrium.pages.dev |
No we should not. But we have the couplings coming back from the prediction so we should check from the result if there are some couplings or not. I would put a threshold of 1.5Hz in order to display the cosy coupling or not. So we should not simply use 2J or 3J anymore but use the result from the prediction. |
5716ff7
to
0dae656
Compare
41dca64
to
d79712f
Compare
d79712f
to
e5b1bc1
Compare
e5b1bc1
to
cb53890
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The COSY prediction seems indeed much more accurate.
It can be tested from:
https://3307-manual-range-picking-re.nmrium.pages.dev/#/SamplesDashboard/8kbdgnwtkbi/Prediction
We now have:
And before it was wrongly:
@jobo322 Is this PR related to issues ? For COSY I agree it works correctly now. |