New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on weights V2 #2694

Closed

dandanlen opened this issue Jan 11, 2023 · 1 comment · Fixed by #2731

Collaborator

dandanlen commented Jan 11, 2023

This is a good resource: paritytech/polkadot-sdk#256

We may need to make changes to our weights calculations - this is especially important in cases where we use on_finalize.

Context:
#2682 (comment)_

dandanlen mentioned this issue

feat: substrate upgrade. monthly-2022-06 to monthly-2022-12 #2682

Merged

kylezs linked a pull request

that will close this issue

chore: update weights template #2731

Merged

Collaborator Author

dandanlen commented Jan 20, 2023

Closing this - TLDR nothing needs to change for now.

The new Weight type contains an extra variable to denote storage bandwidth but so far this appears to be unused.

dandanlen closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment