Enhance shift value and types of shift instructions. #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shifts via registers now save the register id in cs_arch64_op.shift.value and set the shift type accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shifts via registers now save the register id in cs_arch64_op.shift.value and set the shift type accordingly.
Your checklist for this pull request
Detailed description
This streamlines the whole shift operands for AArch64.
It fixes the bug of #2631 (shift immediate was not saved in
shift.value).Additionally, if a register is used for shifting, it saves this register in
shift.value.This is the same behavior as the ARM module have. And is in general more convenient.
Test plan
Added tests for all common shift instructions and their variants.
Closing issues
closes #2631