Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): add network device resources #376

Merged
merged 14 commits into from
Jun 23, 2023
Merged

Conversation

bpg
Copy link
Owner

@bpg bpg commented Jun 20, 2023

This is a PoC / experimental work, focused on using Plugin Framework for the provider / resources implementation.

Add new resources

  • proxmox_virtual_environment_network_linux_vlan
  • proxmox_virtual_environment_network_linux_bridge

See resource documentation for more details.

Contributor's Note

Please mark the following items with an [x] if they apply to your PR.
Leave the [ ] if they are not applicable, or if you have not completed the item.

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /examples for any new or updated resources / data sources.
  • I have ran make examples to verify that the change works as expected.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes: #340

@bpg bpg changed the title Add network device resources feat(vm): Add network device resources Jun 20, 2023
@bpg bpg force-pushed the add-network-device-resource branch from 9372ce4 to 4d9ac6b Compare June 20, 2023 15:57
@bpg bpg changed the title feat(vm): Add network device resources feat(vm): add network device resources Jun 23, 2023
@bpg bpg marked this pull request as ready for review June 23, 2023 22:28
mergify[bot]
mergify bot previously approved these changes Jun 23, 2023
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg enabled auto-merge (squash) June 23, 2023 22:46
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg merged commit 343e804 into main Jun 23, 2023
@bpg bpg deleted the add-network-device-resource branch June 23, 2023 22:47
@ghost ghost mentioned this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Please create a resource for a network interface?
1 participant