Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite OpenSourcePage to M3 #740

Closed
Tracked by #691
rfc2822 opened this issue Apr 21, 2024 · 0 comments · Fixed by #755
Closed
Tracked by #691

Rewrite OpenSourcePage to M3 #740

rfc2822 opened this issue Apr 21, 2024 · 0 comments · Fixed by #755
Assignees
@ArnyminerZ
Labels
refactoring Internal improvement of existing functions

Comments

@rfc2822
Copy link
Member

rfc2822 commented Apr 21, 2024 •
edited
Loading

For the intro pages, I'd keep the current file layout (IntroPage subclass with nested Composables and Model) for now.

However UI (rendering state + producing events) and UI logic (ViewModel to produce state) should be separated. In case of OpenSourcePage I think there will be not much to do.
@rfc2822 rfc2822 mentioned this issue Apr 21, 2024
Closed
12 tasks
@rfc2822 rfc2822 added the refactoring Internal improvement of existing functions label Apr 21, 2024
@ArnyminerZ ArnyminerZ linked a pull request Apr 28, 2024 that will close this issue
Rewrite OpenSourcePage to M3 #755
Merged
4 tasks
@rfc2822 rfc2822 mentioned this issue Apr 30, 2024
Merged
4 tasks
@ArnyminerZ ArnyminerZ moved this from Todo to In Review in DAVx⁵ Releases Apr 30, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in DAVx⁵ Releases May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArnyminerZ ArnyminerZ

Labels
refactoring Internal improvement of existing functions
Projects
DAVx⁵ Releases
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite OpenSourcePage to M3 bitfireAT/davx5-ose
2 participants
@rfc2822 @ArnyminerZ