Rewrite to Compose (meta-issue)

[rfc2822]

The idea is to replace XML layouts by Compose.

This should be done gradually and in small, testable steps. For every Activity / Fragment replaced, there should be a separate PR and with every app release, some parts can be replaced (but not everything at once).

The single sub-PRs shouldn't add features or UI enrichment, but provide a minimum Compose replacement for the existing functionality. Ideally,

• users won't even notice the change,
• the code is more clean and components are better separated,
• the PR is easy to test and review,
• (the number of lines reduces or stays roughly the same)

This is a meta-issue, so it shouldn't get a PR. Every subtask should get one PR. To have a good project flow, please don't change things here or convert tasks to issues yourself.

• Rewrite classes in ui
  • Rewrite AboutActivity
  • Rewrite DebugInfoActivity #482 - Depends on Rewrite TasksActivity, TasksFragment #479
  • Rewrite ExceptionInfoFragment #483
  • Rewrite PermissionsActivity, PermissionsFragment to Compose #575
  • Rewrite TasksActivity, TasksFragment #479
  • Rewrite AccountsDrawerHandler + logic
• Rewrite classes in ui.account
  • Rewrite AccountActivity
  • Rewrite AddressBooksFragment
  • Rewrite CalendarsFragment
  • Rewrite CollectionInfoFragment
  • Rewrite CollectionsFragment
  • Rewrite CreateAddressbookActivity #556
  • Rewrite CreateCalendarActivity to Compose #639
  • Rewrite CreateCollectionFragment - Depends on Rewrite ExceptionInfoFragment #483
  • Rewrite DeleteCollectionFragment - Depends on Rewrite ExceptionInfoFragment #483
  • Rewrite RenameAccountFragment #557
  • Rewrite AccountSettingsActivity #641
  • Rewrite WebcalFragment
  • Rewrite WifiPermissionsActivity to Compose #638
• Rewrite IntroActivity to Compose #625
  • first keep the pages as Fragments and just rewrite the content to Compose
  • as soon as all pages are rewritten and the changes are merged, separate PR that converts the Fragments to pages (BatteryOptimizationsPage etc.) and embed them as Composables
    • Rewrite BatteryOptimizationsFragment to Compose #579
    • Rewrite OpenSourceFragment to Compose #578
    • Rewrite PermissionsIntroFragment to Compose #576
    • Rewrite WelcomeFragment to Compose #577
• Rewrite classes in ui.setup Rewrite login activity + fragments to Compose #667 – should probably also address [When very low memory] Service detection runs forever when certificate is rejected #560
• Rewrite classes in ui.webdav
  • Rewrite AddWebdavMountActivity #629
  • Rewrite WebdavMountsActivity to Compose #604
• Create a native Material theme and get rid of XML styles #674

[ArnyminerZ]

To have a good project flow, please don't change things here or convert tasks to issues yourself.

Oops, I've just read this. Is there any issue? 😅

[jonatbergn]

Are you considering compose multiplatform?

[ArnyminerZ]

Are you considering compose multiplatform?

Why'd you want the app on other platforms? It specifically integrates with Android's Calendar and Contacts provider, which doesn't exist in other OSes. iOS has its own ical support, and in Windows you can use WSA, but there's no such thing as calendar or contacts sharing between apps.

So yeah, right now we are going to stick with Android, however, we are open for suggestions.

[github-actions]

This PR/issue depends on:

• Rewrite TasksActivity, TasksFragment #479
• Rewrite ExceptionInfoFragment #483

[rfc2822]

It's done!