-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing glob
dependency
#623
Comments
it is worth noting that choosing your dependencies purely based on number of downloads isn't the best idea (re the closed PR) fdir is much faster than existing glob libraries, even when combined with picomatch (to provide glob functionality). tinyglobby does not have as many downloads but is built on top of fdir, which is a well established library. this repo would benefit from the performance improvement, and from reduction in install size splitting the package seems like a larger effort that should be discussed/worked on at some other later point |
Another option is to switch to native glob, once it's made it into an LTS or two. nodejs/node#51912 |
Yeah, I think we should. But I believe it's only available in Node 22, which means we'd probably be waiting until 2026 It could be worth using |
That's fair. Let's go ahead and use Feel free to re-open and rebase your PR when you're ready. |
Included in 15.0.3. |
glob
is responsible for 26 out of 37 dependencies for this library: https://npmgraph.js.org/?q=json-schema-to-typescript. I'd love to see if we can find a way to reduce that.A few options I can think of:
fdir
(1M downloads / wk) andpicomatch
(50m downloads / wk)tinyglobby
in Use tinyglobby for globbing #622. See that PR for the full background and additional details regarding this issuejson-schema-to-typescript
and re-export the stuff contained in core, so that users could continue to install just the one package they need and the change could be made in a backwards-compatible fashion. This would also remove other packages likeminimist
andis-glob
from the core dependencies as wellThe text was updated successfully, but these errors were encountered: