Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 22 CI workflows failing #10378

Closed
PyvesB opened this issue Jul 18, 2024 · 2 comments
Closed

Node 22 CI workflows failing #10378

PyvesB opened this issue Jul 18, 2024 · 2 comments
Labels
developer-experience Dev tooling, test framework, and CI needs-upstream-help Not actionable without help from a service provider

Comments

@PyvesB
Copy link
Member

PyvesB commented Jul 18, 2024

npm ci is failing with the following error:

Exit handler never called!

This error has been reported multiple times already, e.g.: npm/cli#7657

We could do some version pinning, but hopefully this can be resolved in the next few days, I suggest we wait for the fix to be rolled out, and trust the output of our Node 20 workflows for the time being.

@PyvesB PyvesB added needs-upstream-help Not actionable without help from a service provider developer-experience Dev tooling, test framework, and CI labels Jul 18, 2024
@chris48s
Copy link
Member

This is now fixed upstream apparently
npm/cli#7657 (comment)

There's a bunch of PRs approved and ready to merge. Might be worth seeing if node v22.5.1 is available to GH actions yet. If it is then the builds should be able to pass now.

If it is not, I reckon just bypass the checks on those PRs for now to get them merged.

@chris48s
Copy link
Member

node 22.5.1 is available to github actions and node 22 builds are running as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI needs-upstream-help Not actionable without help from a service provider
Projects
None yet
Development

No branches or pull requests

2 participants