Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimentalIdentityAndAuth): add aliases for httpSigningMiddleware #970

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

syall
Copy link
Contributor

@syall syall commented Sep 27, 2023

Issue #, if available:

N/A.

Description of changes:

Add aliases for httpSigningMiddleware:

  • @httpApiKeyAuth: apiKeyMiddleware
  • @httpBearerAuth: tokenMiddleware
  • @aws.auth#sigv4: awsAuthMiddleware

If one or more of the packages in the /packages directory has been modified, be sure yarn changeset add has been run and its output has
been committed and included in this pull request. See CONTRIBUTING.md.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ware`

- `@httpApiKeyAuth`: `apiKeyMiddleware`
- `@httpBearerAuth`: `tokenMiddleware`
- `@aws.auth#sigv4`: `awsAuthMiddleware`
@syall syall force-pushed the add-alias-httpSigningMiddleware branch from df615e8 to d69850d Compare September 27, 2023 22:07
@@ -10,6 +10,7 @@ export const httpSigningMiddlewareOptions: FinalizeRequestHandlerOptions & Relat
step: "finalizeRequest",
tags: ["HTTP_SIGNING"],
name: "httpSigningMiddleware",
aliases: ["apiKeyMiddleware", "tokenMiddleware", "awsAuthMiddleware"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future eyes: eventStreamHandlingMiddleware (more likely this) and eventStreamHeaderMiddleware may need to be added to this list.

@syall syall marked this pull request as ready for review September 27, 2023 22:26
@syall syall requested review from a team as code owners September 27, 2023 22:26
@syall syall merged commit 890feeb into smithy-lang:main Sep 28, 2023
@syall syall deleted the add-alias-httpSigningMiddleware branch September 28, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants