Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ASCII replacement for character 0xE2 #866

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Aug 11, 2023

Issue #, if available:

Internal JS-4583

Description of changes:

Uses ASCII replacement for character 0xE2.

We started seeing build failures when attempting to build smithy-typescript on AL2023

> Task :smithy-typescript-codegen:javadoc FAILED
/smithy-typescript/smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/RuleSetParameterFinder.java:132: error: unmappable character (0xE2) for encoding US-ASCII
     * The contextParam trait allows for binding a structure???s member value to a context

Verified that build is successful on AL2023 instance after this fix.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested review from a team as code owners August 11, 2023 19:59
@trivikr trivikr merged commit b45f511 into smithy-lang:main Aug 11, 2023
@trivikr trivikr deleted the use-acii-for-0xE2 branch August 11, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants